Update Filesystem.cs #3322
Open
Update Filesystem.cs #3322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made disk space check more reliable.
lokzz
added a commit
to lokzz/bloxstrap
that referenced
this pull request
Dec 30, 2024
adds pr: (bloxstraplabs#3322)
bluepilledgreat
requested changes
Mar 1, 2025
| catch (ArgumentException e) | ||
| { | ||
| App.Logger.WriteLine("Filesystem::BadPath", $"The path: {p} does not contain a valid drive info."); | ||
| return -1 |
There was a problem hiding this comment.
Missing ;, code won't compile.
| if (path.ToUpperInvariant().StartsWith(drive.Name)) | ||
| return drive.AvailableFreeSpace; | ||
| var isUri = Uri.TryCreate(p, UriKind.RelativeOrAbsolute, out var u); | ||
| if (!Path.IsPathRooted(p) || !Path.IsPathFullyQualified(p) || (isUri && (u?.IsUnc??false))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made disk space check more reliable.
No need to iterate each device and compare. Should be able to get directly from path.