Mobile variants #446
Open
Mobile variants #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applications can configure isMobile function, which should be called by authorization modules whenever they need to establish if mobile vs. full login pages need to be rendered. Most oauth/oauth2 providers are capable of disvoring mobile browsers without any external help. But some applications may prefer to force a specific version (for example based on user preferences). isMobile determination can be done on a per request basis (request is passed as a parameter)
authorizePath is used to redirect user to authorization provider's login screen Extracting building this path into a separate configurable function allows module developers to overwrite default everyauth behavior. It's needed to support some quirky oauth providers that do not follow typical patterns. It's also helpful if provider requires a different URLs for mobile and full version of login screens. Existing modules do not have to be changed unless (or until) they want to use this new functionality.
Implemented buildAuthorizeApp to redirect user either to full or mobile version of tripit login screen Tripit does not recognize browser type automatically
Redirect user to full or mobile version of the application based on the value returned by the isMobile configurable. Older, facebook specific, functionality of forcing mobile/full version by calling 'mobile' function is still supported.
pirxpilot
force-pushed
the
mobile-variants
branch
from
f605393 to
ec38d79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applications can configure
isMobilefunction, which should be called by authorization modules whenever they need to establish if mobile vs. full login pages need to be rendered.Most oauth/oauth2 providers are capable of discovering mobile browsers without any external help. But some applications may prefer to force a specific version (for example based on user preferences).
isMobile determination can be done on a per request basis (request is passed as a parameter)
Existing modules do not have to be changed unless (or until) they want to use this new functionality.