Skip to content

Conversation

@daveoconnor
Copy link
Collaborator

This is related to ticket #1796.

This PR fixes ctrl/meta-clicks work so they work consistently with clicks on the libraries list page, just opening a new tab/window instead.

Testing: click and control click on all three library listing views should work consistently.

@karimarie67
Copy link
Collaborator

Tested in localhost. Ctrl+click is opening new tabs from all links tried on the library crds in addition to testing doc/library links from other areas. Ready to merge @daveoconnor once @gregjkal reviews.

Copy link
Member

@rbbeeston rbbeeston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is JS code, I've looked it over, and I'm fine with merging it. nothing out of the ordinary

@daveoconnor daveoconnor merged commit 1ec3cba into develop Oct 22, 2025
4 checks passed
@daveoconnor daveoconnor deleted the doc/1796-ctrl-clicks branch October 22, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants