Fix: Replace inspect.getargspec with inspect.signature for Python 3.1… #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Python versions 3.11 and newer, the bottle-sqlite plugin currently raises an AttributeError: module 'inspect' has no attribute 'getargspec'. This occurs because inspect.getargspec was deprecated in Python 3.0 and completely removed in Python 3.11, being replaced by inspect.signature.
This pull request updates the apply method to use inspect.signature when inspect.getargspec is not available. A try-except AttributeError block has been implemented to handle the absence of getargspec, ensuring that the plugin remains compatible with both older Python versions (which still have getargspec) and newer versions (Python 3.11+).
The logic now attempts to use inspect.getargspec first, and if an AttributeError is caught, it falls back to using inspect.signature to retrieve the function's parameters.