Add output:flush_frequency for OptionsNetCDF
#2934
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Appears on include guard instead of class
Avoids rewriting time-independent data, gives slight performance boost
* next: (563 commits)
Bump DOI
Add shim for ARKodeGetNumRhsEvals
Suppress warning from `nodiscard` function
Remove `boututils` from requirements; bump `boutdata`
Fix deprecation warning
Bump bundled fmt
Fix some easy clang-tidy snes warnings
Fix reorder warning from snes
CI: Don't run clang-{tidy,format} on RC branches
Update changelog
Bump version to 5.2.0
Tweak version updater, mention in docs
Add dependencies to changelog updater
Add new authors
Tweak citations updater, mention in docs
Update translations
Fix testCommandLineOptionsArePrinted
Apply black changes
Prevent SignalHandlerTestDeathTest when OS is FreeBSD
Use the portable "/usr/bin/env bash" shebang instead of "/bin/bash"
...
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| }; | ||
|
|
||
| /// Set timestep counter for flushing file | ||
| void setFlushCounter(std::size_t iteration) { flush_counter = iteration; } |
There was a problem hiding this comment.
warning: no header providing "std::size_t" is directly included [misc-include-cleaner]
include/bout/physicsmodel.hxx:34:
- class PhysicsModel;
+ #include <cstddef>
+ class PhysicsModel;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort of fixes #2878
Two things:
output:flush_frequencycan be used to reduce how often netCDF data is flushed to disk (maybeflush_periodis a more accurate name?)Optionsused to store data to be written to disk is now reset after writingThese two together can significantly cut the time spent in IO:
(absolute time from the
iotimer forconductionexample for 500 timesteps, rolling average over 100 steps)The red line is basically current
nextI'm a bit concerned that we still get an increase over time, but this seems to unavoidable.
This PR also includes some drive-by fixes for some minor
OptionsIOissues.