ARKODE_MRI interface #3013
Open
ARKODE_MRI interface #3013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drreynolds
reviewed
Nov 5, 2024
drreynolds
reviewed
Jan 6, 2025
|
I think it should be ready now for your reviews @bendudson @drreynolds |
Provides an error message if arkode_mri solver is requested but BOUT++ was built with a version of SUNDIALS lower than 7.2.0
PhysicsModel now has fast and slow preconditioners, and these can be called by the Arkode MRI solver.
Previous use of ARKStepGetNumRhsEvals is deprecated from SUNDIALS 7.2.0, replaced by ARKodeGetNumRhsEvals https://github.com/LLNL/sundials/blob/main/CHANGELOG.md#deprecation-notices
Rather than calling `ARKodeGetCurrentStep` every rhs() call, only call when the `getCurrentTimestep()` method is called.
When run_rhs is called (e.g. by CVODE), all rhs functions are called (rhs_se, rhs_si, rhs_fe, rhs_fi), so all counters need to be incremented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARKODE MRI interface
An integrated test with ARKODE MRI interface