Skip to content

Housekeeping #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 26, 2024
Merged

Housekeeping #23

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
215bf7f
chore: bump eslint*
nikku Jul 25, 2024
5f7c468
chore: update to mocha@8
nikku Jul 25, 2024
545a38b
chore: include package-lock
nikku Jul 25, 2024
18501ac
chore: use `package.json#files` to define published assets
nikku Jul 25, 2024
48702e4
chore: drop UMD distribution
nikku Jul 25, 2024
aca8388
chore: update to rollup@4
nikku Jul 25, 2024
adbf9a9
chore: mark `min-dash` as external dependency
nikku Jul 25, 2024
ab9434b
deps: update to min-dash@4
nikku Jul 25, 2024
a636092
ci: replace Travis with GitHub action
nikku Jul 25, 2024
f4fa6f6
deps: update to bpmn-moddle@9
nikku Jul 25, 2024
22dc17d
deps: update to diffpatch@0.6.0
nikku Jul 26, 2024
3572ab5
chore: drop legacy hack
nikku Jul 26, 2024
f1c9fc0
chore: turn into ES module
nikku Jul 26, 2024
8f465fd
chore: update to bpmn-moddle@9
nikku Jul 26, 2024
7b97bd8
chore: drop unnecessary extra task
nikku Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 17 additions & 35 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bpmn-moddle 8 or 9? 🤔

Copy link
Member Author

@nikku nikku Jul 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v9 does not fly yet, because the diffpatch library we use is a fake ESM module, we cannot move to ESM testing, but bpmn-moddle@9 does not work with emulation via esm anymore.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was asking because the commit message and the actual version weren't matching. 🙂

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise this PR looks good and could be merged.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bpmn-io/diffpatch#2 should enable (once released and integrated) the update to bpmn-moddle@9.

Copy link
Member Author

@nikku nikku Jul 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There you go: 8f465fd ✔️

Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"license": "MIT",
"devDependencies": {
"@rollup/plugin-node-resolve": "^15.2.3",
"bpmn-moddle": "^5.1.3",
"bpmn-moddle": "^8.1.0",
"chai": "^4.1.2",
"eslint": "^8.57.0",
"eslint-plugin-bpmn-io": "^1.0.1",
Expand Down
Loading