Housekeeping

.eslintrc

@@ -1,3 +1,3 @@
 {
-  "extends": "plugin:bpmn-io/es6"
+  "extends": "plugin:bpmn-io/recommended"
 }

.github/workflows/CI.yml

@@ -0,0 +1,23 @@
+name: CI
+on: [ push, pull_request ]
+jobs:
+  Build:
+    runs-on: ${{ matrix.os }}
+
+    strategy:
+      matrix:
+        os: [ubuntu-latest]
+        node-version: [ 20 ]
+
+    steps:
+    - name: Checkout
+      uses: actions/checkout@v4
+    - name: Use Node.js ${{matrix.node-version}}
+      uses: actions/setup-node@v4
+      with:
+        node-version: ${{matrix.node-version}}
+        cache: 'npm'
+    - name: Install dependencies
+      run: npm ci
+    - name: Build
+      run: npm run all

.gitignore

@@ -1,4 +1,3 @@
 node_modules/
 tmp/
-dist/
-package-lock.json
+dist/

README.md

@@ -1,6 +1,6 @@
 # bpmn-js-differ
 
-[![Build Status](https://travis-ci.com/bpmn-io/bpmn-js-differ.svg?branch=master)](https://travis-ci.com/bpmn-io/bpmn-js-differ)
+[![CI](https://github.com/bpmn-io/bpmn-js-differ/actions/workflows/CI.yml/badge.svg)](https://github.com/bpmn-io/bpmn-js-differ/actions/workflows/CI.yml)
 
 A semantic diffing utility for BPMN 2.0 files. To be used together with [bpmn-moddle](https://github.com/bpmn-io/bpmn-moddle).
 

lib/change-handler.js

@@ -91,13 +91,9 @@ ChangeHandler.prototype.removed = function(model, property, element, idx) {
     if (!this._removed[tracked.element.id]) {
       this._removed[tracked.element.id] = element;
     }
-  } else
-
-  if (tracked = isTracked(model)) {
+  } else if (tracked = isTracked(model)) {
     this.changed(tracked.element, tracked.property + property + '[' + idx + ']', null, element);
-  } else
-
-  if (isDi(model) && property === 'waypoint') {
+  } else if (isDi(model) && property === 'waypoint') {
     this._layoutChanged[model.bpmnElement.id] = model.bpmnElement;
   }
 };
@@ -108,9 +104,7 @@ ChangeHandler.prototype.changed = function(model, property, newValue, oldValue)
 
   if (isDi(model)) {
     this._layoutChanged[model.bpmnElement.id] = model.bpmnElement;
-  } else
-
-  if (tracked = isTracked(model)) {
+  } else if (tracked = isTracked(model)) {
     var changed = this._changed[tracked.element.id];
 
     if (!changed) {
@@ -131,17 +125,14 @@ ChangeHandler.prototype.added = function(model, property, element, idx) {
     if (!this._added[tracked.element.id]) {
       this._added[tracked.element.id] = element;
     }
-  } else
-
-  if (tracked = isTracked(model)) {
+  } else if (tracked = isTracked(model)) {
     this.changed(tracked.element, tracked.property + property + '[' + idx + ']', element, null);
-  } else
-
-  if (isDi(model) && property === 'waypoint') {
+  } else if (isDi(model) && property === 'waypoint') {
     this._layoutChanged[model.bpmnElement.id] = model.bpmnElement;
   }
 };
 
 ChangeHandler.prototype.moved = function(model, property, oldIndex, newIndex) {
+
   // noop
 };

lib/differ.js

@@ -76,8 +76,7 @@ Differ.prototype.diff = function(a, b, handler) {
 
           if (added || (removed && !moved)) {
             handler[removed ? 'removed' : 'added'](model, key, val[0], idx);
-          } else
-          if (moved) {
+          } else if (moved) {
             handler.moved(model, key, val[1], val[2]);
           } else {
             walk(val, model[key][idx]);