Flexible playground components #298
Conversation
pinussilvestrus
force-pushed
the
286-properties-panel-module
branch
from
6e66134 to
ecbc38c
Compare
pinussilvestrus
force-pushed
the
292-flexible-playground-components
branch
2 times, most recently
from
1f1f7ba to
869956d
Compare
pinussilvestrus
force-pushed
the
286-properties-panel-module
branch
from
ecbc38c to
a385a1a
Compare
pinussilvestrus
force-pushed
the
292-flexible-playground-components
branch
from
869956d to
84ac01e
Compare
pinussilvestrus
requested review from
a team,
Skaiir,
barmac and
philippfromme
and removed request for
a team
This comment was marked as resolved.
This comment was marked as resolved.
pinussilvestrus
force-pushed
the
292-flexible-playground-components
branch
from
84ac01e to
4310736
Compare
bpmn-io-tasks
bot
added
needs review
|
Ready for review now. |
pinussilvestrus
force-pushed
the
292-flexible-playground-components
branch
from
4310736 to
49d6383
Compare
pinussilvestrus
force-pushed
the
292-flexible-playground-components
branch
from
49d6383 to
5c712c1
Compare
|
@Skaiir @barmac @philippfromme, maybe any chance to get a review for this? 🙂 |
|
I missed this. Thanks for notice. |
| { | ||
| name: 'data', | ||
| attachFn: 'attachDataContainer', | ||
| selector: 'cm-editor' | ||
| }, | ||
| { | ||
| name: 'result', | ||
| attachFn: 'attachResultContainer', | ||
| selector: 'cm-editor' | ||
| }, |
There was a problem hiding this comment.
Should these two have the same selector?
There was a problem hiding this comment.
I thought about adding a custom class name to each Code Mirror instance. However, it was not possible (at least not clearly documented). That's why I keep things as they are; you can still handle/style each editor via parent selectors.
There was a problem hiding this comment.
I was afraid that having the same selector in the tests can make us think data container is attached while it's the result container. If that's not the case, we can ignore it.
There was a problem hiding this comment.
As we now remove every container after each test, it shouldn't be the case.
There was a problem hiding this comment.
I think we are fine.
pinussilvestrus
force-pushed
the
292-flexible-playground-components
branch
from
5c712c1 to
69fba93
Compare
2 participants
Closes #292
This makes it possible to attach all playground components individually. This enables a mode for the playground to render nothing (by not providing
containerconfig) but only orchestrate the different instances. This is a requirement to create a product-specific playground version (cf. https://github.com/bpmn-io/internal-docs/issues/527).This also makes the "actions" (download, embed) optional.
Overview components
Demo
Check out this demo to get a feeling of what you can do with the API changes.