Skip to content

Updated rules for phpcs security audit #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release-candidate
Choose a base branch
from
Open

Updated rules for phpcs security audit #1261

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b91c4b
updated rules for phpcs security audit
Jul 18, 2025
11821cb
added phpcs rules for security purposes
Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@
"phpstan/phpstan": "^1.11",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What: Ensure that the update of the composer.json does not conflict with existing packages or introduce any versioning issues.

Why: Maintaining compatibility between various packages is crucial to avoid runtime errors or dependency conflicts that may arise during installation.

How: Review the currently installed versions and check for compatibility with the pheromone/phpcs-security-audit package. Running composer validate before merging could also help identify any issues.

"php-stubs/generator": "^0.8.4",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What: Consider providing a brief note on the necessity of adding the pheromone/phpcs-security-audit package.

Why: Documentation is key for team collaboration and future reference. It helps maintain clarity on why certain packages are included, especially for security-related tools.

How: You might add a comment above the new package entry in composer.json: // Added for enhanced security audit checks. This will help others understand the intention behind the change.

"php-stubs/wordpress-stubs": "^6.5",
"szepeviktor/phpstan-wordpress": "^1.3"
"szepeviktor/phpstan-wordpress": "^1.3",
"pheromone/phpcs-security-audit": "^2.0"
},
"scripts": {
"format": "phpcbf",
Expand Down
Loading