Added a single form design for display conditions #1315
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1 +1 @@ | |||
| <?php return array('dependencies' => array('react', 'react-dom', 'wp-api-fetch', 'wp-dom-ready', 'wp-element', 'wp-i18n', 'wp-polyfill'), 'version' => '1bc15358d60487785f93'); | |||
There was a problem hiding this comment.
What: The version identifier has been updated, but it's unclear what changes were introduced in this version.
Why: It is important to maintain documentation or comments regarding what changes or updates are included with each version number. This assists in tracking changes that may impact security, performance, or overall functionality.
How: Consider adding a comment block above the version declaration explaining what has been included in this new version. For instance, indicate the purpose of the update, any new features, bug fixes, or performance improvements made.
build/main.css
Outdated
| @@ -1,4 +1,10 @@ | |||
| /*!************************************************************************************************************!*\ | |||
There was a problem hiding this comment.
What: Consider removing the commented-out source map URL altogether if it's not needed for production.
Why: Leaving commented-out code in the production file can create unnecessary clutter and confusion. If source maps are not required, it is cleaner to not have them at all.
How: You can safely remove the line //# sourceMappingURL=main.css.map from the end of the file if you're not using source maps.
| font-style: normal; | ||
| font-display: swap; | ||
| font-weight: 400; | ||
| src: url(/8fbf595b398521a13438.woff2) format('woff2'), url(/7d00956da27af3e30b78.woff) format('woff'); |
There was a problem hiding this comment.
What: Ensure that the font-face sources are available and correctly referenced.
Why: Incorrect or missing font sources can lead to performance issues, and if fonts do not load, it impacts the user experience.
How: Verify the provided URLs for font sources like /8fbf595b398521a13438.woff2 and ensure they are correctly served from your backend or hosting.
| font-style: italic; | ||
| font-display: swap; | ||
| font-weight: 400; | ||
| src: url(/0c658d1bd687fc3b8ae1.woff2) format('woff2'), url(/f2b6d272f68d05e1513a.woff) format('woff'); |
There was a problem hiding this comment.
What: If you are using the same font family for different styles, ensure that you are not loading them multiple times unnecessarily.
Why: Multiple font downloads can increase loading time even if they are the same font family. Consolidating similar font-face declarations can improve load times and reduce data usage.
How: Check if you can combine the @font-face definitions for Figtree by including weights and styles in a single declaration instead of separate blocks.
Fixed Layout Name Editing
…Canvas pages toggle
Description
Main Purpose: This pull request refines the user interface by consolidating the form design for display conditions in the project, making it more streamlined and user-friendly.
Key Changes:
withDisplayConditionscomponent insrc/Components/HF-Builder/DisplayConditionsDialog.jsxto remove old tab navigation and local storage functionality for active tabs.Additional Notes:
Screenshots
Types of changes
How has this been tested?
Checklist: