Fix: Update render to execute injectIntoDevTools once #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @brianzinn please take a look to this PR. |
|
First of all thank-you for your contribution and sorry for leaving this so long. I am trying to clean up the issues and merge all the PRs. if you are still available and willing... The code-sandbox is really helpful, but I am unable to reproduce on FF or Edge with React Dev Tools. I am clicking the "GenerateKey" button and it resets the scene correctly with no errors and the Components tab seems to be working. I don't know if Dev Tools has been updated in the interim to allow being called multiple times or if I am doing something incorrectly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the error:
This is reproducible when we try to unmount a Scene to generate a new component changing the key react prop:
https://codesandbox.io/p/sandbox/codesandbox-react-tsx-forked-chj46s
Please open the codesanbox repro example in a separate tab, because only happens when your browser has React DevTools extension.
This fix is based on this issue:
pixijs/pixi-react#251