vector: report const as null if base value is null #6475
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When getting the value of a primitive const at a given slot, report the value as null if the base value is null.
nwt
reviewed
Dec 29, 2025
| return vec.Bits.IsSet(slot), vec.Nulls.IsSet(slot) | ||
| case *Const: | ||
| return vec.Value().Ptr().AsBool(), vec.Nulls.IsSet(slot) | ||
| return vec.Value().Ptr().AsBool(), vec.val.IsNull() || vec.Nulls.IsSet(slot) |
Member
There was a problem hiding this comment.
I really think this is the wrong approach and that the nulls vector should be the source of truth, with the implication that a vector.Const with a null super.Value should always have every bit set in its nulls vector.
Collaborator
Author
There was a problem hiding this comment.
I don't feel strongly about this but I'd like to make sure this works someday in the near future. I can't assess whether what you are proposing is a quick fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting the value of a primitive const at a given slot, report the value as null if the base value is null.