Include MessageExtractor code in fulltext #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Why not just fork and add to PyPI? |
Contributor
Author
|
I'm not the owner so I cannot register MsgExtractor on PYPI. I filed a couple of issues on MsgExtractor bug tracker asking if they're interested in packaging it properly and put it on PYPI (they are). I made an initial PR but it's not reviewed/merged yet. Basically we can't properly fix this until they push it forward. |
Contributor
Author
|
Have your issues been fixed in the most recent version of msg-extractor? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MsgExtractor lib is not easy to deal with in terms of packaging and as a dependency in general, see:
I even disabled travis CI for python 2.7 because it could not get installed:
2b01185
With this PR I just include it in fulltext code base. This will make builds faster as it's one less dep to retrieve from GIT (there's no MsgExtractor on PYPI).