Skip to content

Conversation

@btucker
Copy link
Owner

@btucker btucker commented Nov 8, 2025

The build was failing because the .pyx and .pxd files were not included in the source distribution, causing this error:
ValueError: 'applefoundationmodels/_foundationmodels.pyx' doesn't match any files

Changes:

  • Add applefoundationmodels/*.pyx to MANIFEST.in
  • Add applefoundationmodels/*.pxd to MANIFEST.in
  • Add applefoundationmodels/swift/*.h to MANIFEST.in

Summary by CodeRabbit

  • Chores
    • Updated distribution packaging to include all necessary source and header files required for proper compilation.

The build was failing because the .pyx and .pxd files were not included in the source distribution, causing this error:
  ValueError: 'applefoundationmodels/_foundationmodels.pyx' doesn't match any files

Changes:
- Add applefoundationmodels/*.pyx to MANIFEST.in
- Add applefoundationmodels/*.pxd to MANIFEST.in
- Add applefoundationmodels/swift/*.h to MANIFEST.in

This ensures the source distribution (.tar.gz) contains all files needed to build the package from source.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Nov 8, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The MANIFEST.in file was updated to include Cython source files (*.pyx, *.pxd) from the applefoundationmodels directory and Swift header files (*.h) from applefoundationmodels/swift in the source distribution package. These are build-time sources required for compilation.

Changes

Cohort / File(s) Summary
Build manifest configuration
MANIFEST.in
Added include directives for Cython sources (applefoundationmodels/*.pyx, applefoundationmodels/*.pxd) and Swift headers (applefoundationmodels/swift/*.h); retained existing README, LICENSE, and Swift file inclusions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single, straightforward manifest configuration file with additive include directives
  • No logic changes or behavioral implications

Possibly related PRs

Poem

🐰 A manifest grows with sources so fine,
Cython and Swift headers, all in line—
The build box opens, no secrets to hide,
Compilation flows with ease and with pride! ✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/source-dist

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 29e58e3 and b858121.

📒 Files selected for processing (1)
  • MANIFEST.in (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@btucker btucker merged commit 9ba80ae into main Nov 8, 2025
7 of 8 checks passed
@btucker btucker deleted the feature/source-dist branch November 8, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants