Deprecate and hide the timeout flag #4089
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
|
Alternative: bufbuild/app-go#3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates and hides the global
--timeoutflag.This specifically came up with
buf lsp serve, where this command should not have a timeout. As such, we'd want to move--timeoutto non-global anyways, but looking at the problem, it's not entirely clear what we're solving by having this flag in the first place. It was originally added because "all RPCs should have a timeout" but I'm not sure if this really desired or necessary.As such, this just turns it into a no-op. You could theoretically argue that users expecting timeouts today will no longer get them, but this is generally how flags are deprecated, and you get a warning.