FE code to update UseDefaultWorkflowConfig

Author: maggie-lou

app/util/remote_runner.tsx

@@ -10,7 +10,7 @@ const DEFAULT_CONTAINER_IMAGE = "docker://gcr.io/flame-public/rbe-ubuntu24-04:la
 
 export async function supportsRemoteRun(repoUrl: string): Promise<boolean> {
   const rsp = await rpcService.service.getLinkedGitHubRepos(new github.GetLinkedReposRequest());
-  return rsp.repoUrls.filter((url) => url === repoUrl).length > 0;
+  return rsp.repos.some((repo) => repo.repoUrl === repoUrl);
 }
 
 export function triggerRemoteRun(

enterprise/app/workflows/github_app_import.tsx

@@ -164,7 +164,7 @@ export default class GitHubAppImport extends React.Component<GitHubAppImportProp
       .finally(() => this.setState({ linkRequest: null, linkLoading: false }));
   }
   private getLinkedRepoUrls(): Set<string> {
-    return new Set(this.state.linkedReposResponse?.repoUrls || []);
+    return new Set(this.state.linkedReposResponse?.repos?.map((repo) => repo.repoUrl) || []);
   }
 
   private onClickInstallApp() {

enterprise/app/workflows/workflows.tsx

@@ -222,7 +222,7 @@ class ListWorkflowsComponent extends React.Component<ListWorkflowsProps, State>
               </div>
               <div className="title">Workflows</div>
             </div>
-            {Boolean(this.state.workflowsResponse?.workflow?.length || this.state.reposResponse?.repoUrls?.length) && (
+            {Boolean(this.state.workflowsResponse?.workflow?.length || this.state.reposResponse?.repos?.length) && (
               <div className="buttons create-new-container">
                 {isAdmin && <Button onClick={this.onClickCreate.bind(this)}>Link a repository</Button>}
                 <OutlinedLinkButton href="https://docs.buildbuddy.io/docs/workflows-setup" target="_blank">
@@ -233,7 +233,7 @@ class ListWorkflowsComponent extends React.Component<ListWorkflowsProps, State>
           </div>
         </div>
         <div className="content">
-          {!(this.state.workflowsResponse?.workflow?.length || this.state.reposResponse?.repoUrls?.length) && (
+          {!(this.state.workflowsResponse?.workflow?.length || this.state.reposResponse?.repos?.length) && (
             <div className="no-workflows-container">
               <div className="no-workflows-card">
                 <WorkflowsZeroStateAnimation />
@@ -253,17 +253,18 @@ class ListWorkflowsComponent extends React.Component<ListWorkflowsProps, State>
               </div>
             </div>
           )}
-          {Boolean(this.state.workflowsResponse?.workflow?.length || this.state.reposResponse?.repoUrls?.length) && (
+          {Boolean(this.state.workflowsResponse?.workflow?.length || this.state.reposResponse?.repos?.length) && (
             <div className="workflows-list">
               {/* Render linked repositories */}
-              {this.state.reposResponse?.repoUrls.map((repoUrl) => (
+              {this.state.reposResponse?.repos?.map((repo) => (
                 <>
                   <RepoItem
                     user={this.props.user}
-                    repoUrl={repoUrl}
-                    onClickUnlinkItem={() => this.setState({ repoToUnlink: repoUrl })}
-                    onClickInvalidateAllItem={() => this.setState({ repoToInvalidate: repoUrl })}
-                    history={this.renderActionList(repoUrl)}
+                    repoUrl={repo.repoUrl}
+                    useDefaultWorkflowConfig={repo.useDefaultWorkflowConfig}
+                    onClickUnlinkItem={() => this.setState({ repoToUnlink: repo.repoUrl })}
+                    onClickInvalidateAllItem={() => this.setState({ repoToInvalidate: repo.repoUrl })}
+                    history={this.renderActionList(repo.repoUrl)}
                   />
                 </>
               ))}
@@ -274,6 +275,7 @@ class ListWorkflowsComponent extends React.Component<ListWorkflowsProps, State>
                     user={this.props.user}
                     repoUrl={workflow.repoUrl}
                     webhookUrl={workflow.webhookUrl}
+                    useDefaultWorkflowConfig={true} /* Default for legacy workflows */
                     onClickUnlinkItem={() => this.setState({ workflowToDelete: workflow })}
                     onClickInvalidateAllItem={null} /* Not implemented for legacy workflows */
                     history={null}
@@ -332,6 +334,7 @@ type RepoItemProps = {
   user?: User;
   repoUrl: string;
   webhookUrl?: string;
+  useDefaultWorkflowConfig: boolean;
   onClickUnlinkItem: (url: string) => void;
   onClickInvalidateAllItem: ((url: string) => void) | null;
   history: React.ReactNode;
@@ -348,6 +351,7 @@ type RepoItemState = {
   isWorkflowRunning: boolean;
   runWorkflowActionStatuses: workflow.ExecuteWorkflowResponse.ActionStatus[] | null;
   startTime: Date | null;
+  useDefaultWorkflowConfig: boolean;
 };
 
 class RepoItem extends React.Component<RepoItemProps, RepoItemState> {
@@ -361,6 +365,7 @@ class RepoItem extends React.Component<RepoItemProps, RepoItemState> {
     isWorkflowRunning: false,
     runWorkflowActionStatuses: null,
     startTime: null,
+    useDefaultWorkflowConfig: this.props.useDefaultWorkflowConfig,
   };
 
   private onClickMenuButton() {
@@ -376,6 +381,31 @@ class RepoItem extends React.Component<RepoItemProps, RepoItemState> {
     alert_service.success("Copied webhook URL to clipboard!");
   }
 
+  private onClickUpdateDefaultConfig(updated: boolean) {
+    const prev = this.state.useDefaultWorkflowConfig;
+    this.setState({ useDefaultWorkflowConfig: updated });
+
+    const request = new github.UpdateRepoSettingsRequest({
+      repoUrl: this.props.repoUrl,
+      useDefaultWorkflowConfig: updated,
+    });
+
+    rpcService.service
+      .updateGitHubRepoSettings(request)
+      .then(() => {
+        alert_service.success(`Successfully updated repository settings`);
+      })
+      .catch((e) => {
+        this.setState({ useDefaultWorkflowConfig: prev });
+        errorService.handleError(e);
+      });
+  }
+
+  private onClickUpdateDefaultConfigMenuItem() {
+    this.setState({ isMenuOpen: false });
+    this.onClickUpdateDefaultConfig(!this.state.useDefaultWorkflowConfig);
+  }
+
   private onClickUnlinkMenuItem() {
     this.setState({ isMenuOpen: false });
     this.props.onClickUnlinkItem(this.props.repoUrl);
@@ -432,6 +462,10 @@ class RepoItem extends React.Component<RepoItemProps, RepoItemState> {
       .finally(() => this.setState({ isWorkflowRunning: false }));
   }
 
+  isDeprecatedWorkflow(): boolean {
+    return Boolean(this.props.webhookUrl);
+  }
+
   renderWorkflowResults() {
     if (!this.state.runWorkflowActionStatuses) return;
     return this.state.runWorkflowActionStatuses.map((actionStatus) => {
@@ -482,6 +516,12 @@ class RepoItem extends React.Component<RepoItemProps, RepoItemState> {
         <MenuItem onClick={this.onClickInvalidateAllMenuItem.bind(this)}>Invalidate all workflow VM snapshots</MenuItem>
       );
     }
+    if (!this.isDeprecatedWorkflow()) {
+      const configText = this.state.useDefaultWorkflowConfig
+        ? "Disable default workflow config"
+        : "Enable default workflow config";
+      menuItems.push(<MenuItem onClick={this.onClickUpdateDefaultConfigMenuItem.bind(this)}>{configText}</MenuItem>);
+    }
 
     return (
       <div className="workflow-item container">
@@ -493,7 +533,7 @@ class RepoItem extends React.Component<RepoItemProps, RepoItemState> {
                 <Link href={router.getWorkflowHistoryUrl(normalizeRepoURL(this.props.repoUrl))} className="repo-url">
                   {formatURL(this.props.repoUrl)}
                 </Link>
-                {capabilities.config.githubAppEnabled && this.props.webhookUrl && (
+                {capabilities.config.githubAppEnabled && this.isDeprecatedWorkflow() && (
                   <div className="upgrade-notice">
                     <AlertCircle className="icon orange" /> This repository uses the legacy GitHub OAuth integration.
                     Unlink and re-link to use the new GitHub App integration.
@@ -505,7 +545,7 @@ class RepoItem extends React.Component<RepoItemProps, RepoItemState> {
           <div className="workflow-item-column workflow-buttons-container">
             <div className="workflow-item-row">
               {/* The Run Workflow button is only supported for workflows configured with the Github App, not legacy workflows */}
-              {!this.props.webhookUrl && (
+              {!this.isDeprecatedWorkflow() && (
                 <div className="workflow-button-container">
                   <OutlinedButton
                     className="run-workflow-button"

proto/github.proto

@@ -186,9 +186,9 @@ message GitRepository {
   string repo_url = 1;
 
   // Whether to use the default workflow config if buildbuddy.yaml is missing.
-  // If enabled, workflows will automatically start running for a git repo when linked,
-  // even if buildbuddy.yaml is missing from the repo. If disabled, workflows will only run
-  // when buildbuddy.yaml is present in the repo.
+  // If enabled, workflows will automatically start running for a git repo when
+  // linked, even if buildbuddy.yaml is missing from the repo. If disabled,
+  // workflows will only run when buildbuddy.yaml is present in the repo.
   bool use_default_workflow_config = 2;
 }
 
@@ -199,7 +199,6 @@ message GetLinkedReposResponse {
 
   // DEPRECATED: Use repos instead.
   repeated string repo_urls = 2 [deprecated = true];
-
 }
 
 // A request to link a repo to the authenticated org.
@@ -237,6 +236,10 @@ message UpdateRepoSettingsRequest {
 
   string repo_url = 2;
 
+  // Whether to use the default workflow config if buildbuddy.yaml is missing.
+  // If enabled, workflows will automatically start running for a git repo when
+  // linked, even if buildbuddy.yaml is missing from the repo. If disabled,
+  // workflows will only run when buildbuddy.yaml is present in the repo.
   bool use_default_workflow_config = 3;
 }