FIX Module not compatible with translatable #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translatable modifies controller links by adding ?Locale=XX to the URLs. Because this url was being built manually it was generating an incorrect URL. eg. /admin/pages/?Locale=en_NZ/10 instead of /admin/pages/10?Locale=en_NZ
|
To re-produce you need to install the translatable module. After that just try and import a CSV through GridField and then click either 'Cancel' or 'Import CSV'. Both have the same result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translatable modifies controller links by adding ?Locale=XX
to the URLs. Because this url was being built manually it
was generating an incorrect URL.
eg. /admin/pages/?Locale=en_NZ/10 instead of
/admin/pages/10?Locale=en_NZ