Handle dedicated scratch registers in the redundant move eliminator #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a dedicated scratch register is provided by the environment, the redundant move eliminator needs to assume that this register can be clobbered by any instruction. This register can't be specified as a clobber because it is also used by jump instructions which cannot have operands.
Contributor
Author
|
This wasn't caught by the fuzzer because our fuzzing setup doesn't use a dedicated scratch register. I could change that but then we wouldn't be testing the case where regalloc2 needs to find a scratch register on its own. |
cfallin
approved these changes
May 25, 2023
Member
cfallin
left a comment
cfallin
left a comment
There was a problem hiding this comment.
Thanks! Do you need a point release for this?
Contributor
Author
That's not necessary since I'm currently using a fork that includes the changes from #131. Once that is resolved I'd like to switch back to using mainline regalloc2. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a dedicated scratch register is provided by the environment, the redundant move eliminator needs to assume that this register can be clobbered by any instruction.
This register can't be specified as a clobber because it is also used by jump instructions which cannot have operands.