Skip to content

Sightglass CLI: allow hyphens in engine flags. #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fitzgen merged 1 commit into from
Dec 22, 2025
Merged

Sightglass CLI: allow hyphens in engine flags. #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion crates/cli/src/benchmark.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,11 @@ pub struct BenchmarkCommand {

/// Configure an engine using engine-specific flags. (For the Wasmtime
/// engine, these can be a subset of flags from `wasmtime run --help`).
#[structopt(long("engine-flags"), value_name = "ENGINE_FLAGS")]
#[structopt(
long("engine-flags"),
value_name = "ENGINE_FLAGS",
allow_hyphen_values = true
)]
engine_flags: Option<String>,

/// How many processes should we use for each Wasm benchmark?
Expand Down