Avoid executable stack by marking that it's not required. #4418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkroonza
requested review from
loganek,
lum1n0us,
no1wudi,
TianlongLiang,
wenyongh,
xujuntwt95329 and
yamt
as code owners
|
Other assembly files may be affected too, but this is the one that causes problems for me. |
can you consider to apply this to other *.s files? |
|
I can definitely add to all, but I'm not in a position to test all, is that acceptable? |
i think it's fine. |
lum1n0us
added
the
bug-fix
TianlongLiang
approved these changes
Jul 29, 2025
|
Is there a way to cherry pick this over to 1.3 from here or do I push a separate PR again? |
yamt
reviewed
Jul 29, 2025
yamt
approved these changes
Jul 29, 2025
Also refer to: fluent/fluent-bit#10513 Signed-off-by: Jaco Kroon <jaco@uls.co.za>
yamt
reviewed
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refer to: fluent/fluent-bit#10513