-
Notifications
You must be signed in to change notification settings - Fork 713
Enhance WAMR_BUILD_SANITIZER
to support multiple sanitizers
#4489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm not entirely sure if we're following the same approach with command line options, but it seems that ";" is more commonly used than "," in the CMake world for representing a list. I mean https://cmake.org/cmake/help/v3.14/command/list.html#introduction |
I think while ";" is cmake's internal list separator, "," provides better user experience as it doesn't require shell escaping or quotes. moreover, comma-delimited parameters align with industry conventions used by compilers like gcc/clang: |
d526d65
to
60a3c1f
Compare
16eb5e1
to
be123f2
Compare
It appears that it is causing failures in the nightly-run CI. https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/16867922946/job/47777465384
Perhaps, |
resolved. thanks. #4553 |
Support combining compatible sanitizers,
Usage examples:
cmake -DWAMR_BUILD_SANITIZER=ubsan,posan ../
cmake -DWAMR_BUILD_SANITIZER=ubsan ../