Refactor the CMake and related scripts for unit tests #4605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lum1n0us
force-pushed
the
fix/unit_coverage
branch
3 times, most recently
from
808a5d3 to
180b642
Compare
lum1n0us
changed the title
lum1n0us
force-pushed
the
fix/unit_coverage
branch
3 times, most recently
from
02d19d7 to
dd3bf40
Compare
lum1n0us
changed the title
…ollection - only unit/CMakeLists.txt fetches googletest - only unit/unit_common.cmake find LLVM dependencies - use `WAMR_RUNTIME_LIB_SOURCE` to replace a long list
…sm-apps build process
lum1n0us
force-pushed
the
fix/unit_coverage
branch
from
dd3bf40 to
4b4c16e
Compare
lum1n0us
changed the title
lum1n0us
requested review from
TianlongLiang,
loganek,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
| uses: ./.github/actions/install-wasi-sdk-wabt | ||
| with: | ||
| os: ${{ matrix.os }} | ||
|
|
There was a problem hiding this comment.
Maybe keep the empty line
| set (WAMR_BUILD_LIBC_WASI 0) | ||
| set (WAMR_BUILD_APP_FRAMEWORK 0) | ||
| # FIXME: if removed, LibcBuiltinTest.calloc will be failed | ||
| set (WAMR_BUILD_MULTI_MODULE 1) |
There was a problem hiding this comment.
By looking at the code, it shouldn't rely on multi-module; we should look into it in the future, this indeed warrants a FIXME:
| func_test_1.u.func->func_type->param_cell_num = 2; | ||
| func_test_1.u.func->func_type->types[0] = VALUE_TYPE_I64; | ||
| func_test_1.u.func->max_stack_cell_num = 10; | ||
| EXPECT_EQ(false, wasm_runtime_call_wasm_v( |
There was a problem hiding this comment.
Why were those codes removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--ignore-errors) on Ubuntu 24.04 (gcc13). Add a warning to notice that.