Add Nox configuration, to run tests locally across Python versions #301
+28
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was interfering with running tests locally, pytest - scanned .git/ & tried to parse content as Python source - scanned build/ and found duplicates of e.g. wasmtime/_config.py This restores the relavant default globs for norecursedirs, that were previously overridden. https://docs.pytest.org/en/7.1.x/reference/reference.html#confval-norecursedirs E.g. ``` __________ ERROR collecting .git/logs/refs/remotes/origin/issue231-src-dist-version_suffix_in_setup.py __________ .venv/lib/python3.9/site-packages/_pytest/python.py:498: in importtestmodule mod = import_path( .venv/lib/python3.9/site-packages/_pytest/pathlib.py:587: in import_path importlib.import_module(module_name) ../../.local/share/uv/python/cpython-3.9.23-macos-aarch64-none/lib/python3.9/importlib/__init__.py:127: in import_module return _bootstrap._gcd_import(name[level:], package, level) <frozen importlib._bootstrap>:1030: in _gcd_import ??? <frozen importlib._bootstrap>:1007: in _find_and_load ??? <frozen importlib._bootstrap>:986: in _find_and_load_unlocked ??? <frozen importlib._bootstrap>:680: in _load_unlocked ??? <frozen importlib._bootstrap_external>:846: in exec_module ??? <frozen importlib._bootstrap_external>:983: in get_code ??? <frozen importlib._bootstrap_external>:913: in source_to_code ??? <frozen importlib._bootstrap>:228: in _call_with_frames_removed ??? E File "/Users/alex/src/wasmtime-py/.git/logs/refs/remotes/origin/issue231-src-dist-version_suffix_in_setup.py", line 1 E 0000000000000000000000000000000000000000 61c83b6 Alex Willmer <alex@moreati.org.uk> 1749727258 +0100 update by push E ^ E SyntaxError: invalid syntax ``` ``` __________ ERROR collecting src/wasmtime/bindgen/generated/imports/stderr.py __________ import file mismatch: imported module 'wasmtime.bindgen.generated.imports.stderr' has this __file__ attribute: /Users/alex/src/wasmtime-py/build/lib/wasmtime/bindgen/generated/imports/stderr.py which is not the same as the test file we want to collect: /Users/alex/src/wasmtime-py/src/wasmtime/bindgen/generated/imports/stderr.py HINT: remove __pycache__ / .pyc files and/or use a unique basename for your test file modules ```
Nox is a Python CLI tool for running tests or other build/project management tasks. It's invoked as - `nox` or `python3 -m nox` - run every session defined in noxfile.py - `nox --list` - list sessions defined - `nox -s <session>` - Run a particular session - `nox -p <python,...> - Run sessions the use the given python version(s) If desired checks such as MyPy or style can also be included. See https://nox.thea.codes/en/stable/index.html
moreati
changed the title
|
Example usage (full log attached nox.log) ➜ wasmtime-py git:(nox) nox --list
Sessions defined in /Users/alex/src/wasmtime-py/noxfile.py:
* tests-3.9
* tests-3.10
* tests-3.11
* tests-3.12
* tests-3.13
* tests-3.14
sessions marked with * are selected, sessions marked with - are skipped.
➜ wasmtime-py git:(nox) nox
nox > Running session tests-3.9
nox > Creating virtual environment (uv) using python3.9 in .nox/tests-3-9
nox > /Users/alex/.local/share/uv/tools/nox/bin/uv pip install '.[testing]'
nox > coverage run -m pytest
===================================================================================================== test session starts =====================================================================================================
platform darwin -- Python 3.9.23, pytest-8.4.2, pluggy-1.6.0
rootdir: /Users/alex/src/wasmtime-py
configfile: pytest.ini
plugins: mypy-1.0.1
collected 189 items / 1 skipped
ci/build-rust.py .. [ 1%]
ci/cbindgen.py . [ 1%]
ci/download-wasmtime.py . [ 2%]
...
wasmtime/bindgen/generated/types.py . [ 99%]
wasmtime/loader.py . [100%]
============================================================================================================ mypy =============================================================================================================
Success: no issues found in 153 source files
==================================================================================================== 257 passed in 33.87s =====================================================================================================
nox > Session tests-3.14 was successful in 41 seconds.
nox > Ran 6 sessions in 4 minutes:
nox > * tests-3.9: success, took 22 seconds
nox > * tests-3.10: success, took 49 seconds
nox > * tests-3.11: success, took 51 seconds
nox > * tests-3.12: success, took 48 seconds
nox > * tests-3.13: success, took 46 seconds
nox > * tests-3.14: success, took 41 seconds |
|
This PR is offered in the hope it will be useful. No hard feelings if you prefer not to take it, for any reason or no reason. If you wish a similar capability, but less Python-centric, then Just might fit the bill. I used Nox because it's a hammer I know. |
There was a problem hiding this comment.
Thanks! Do you know if uv has a mode similar to cargo +nightly ... which can override which Python version is being used to easily run multiple versions locally? If so I might be more inclined to lean towards that to avoid the need to have an extra dep/runner.
If not, though, would it make sense to integrate this into CI to ensure it stays up-to-date?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's awkward to run the testsuite locally across all supported Python versions, so version specific errors are only found in Github CI jobs.
This change allows the wasmtime-py test suite to be run across all supported CPython versions 3.9 - 3.14 at time of writing. It uses Nox a Python CLI tool for running tests or other build/project management tasks. It's invoked as
noxorpython3 -m nox- run every session defined in noxfile.pynox --list- list sessions definednox -s <session>- Run a particular sessionnox -p <python,...>- Run sessions the use the given python version(s)If desired checks such as MyPy or style can also be included.