Skip to content

Re-enable single-pass regalloc in fuzzing #11721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcrichton merged 1 commit into from
Sep 19, 2025
Merged

Re-enable single-pass regalloc in fuzzing #11721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions crates/fuzzing/src/generators/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,18 +838,14 @@ impl OptLevel {
#[derive(Arbitrary, Clone, Debug, PartialEq, Eq, Hash)]
enum RegallocAlgorithm {
Backtracking,
// FIXME(#11544 and #11545): rename back to `SinglePass` and handle below
// when those issues are fixed
TemporarilyDisabledSinglePass,
SinglePass,
}

impl RegallocAlgorithm {
fn to_wasmtime(&self) -> wasmtime::RegallocAlgorithm {
match self {
RegallocAlgorithm::Backtracking => wasmtime::RegallocAlgorithm::Backtracking,
RegallocAlgorithm::TemporarilyDisabledSinglePass => {
wasmtime::RegallocAlgorithm::Backtracking
}
RegallocAlgorithm::SinglePass => wasmtime::RegallocAlgorithm::SinglePass,
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/all/stack_overflow.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,7 @@ fn big_stack_works_ok(config: &mut Config) -> Result<()> {
// Disable cranelift optimizations to ensure that this test doesn't take too
// long in debug mode due to the large size of its code.
config.cranelift_opt_level(OptLevel::None);
// FIXME(#11544) helps make this test case faster
// config.cranelift_regalloc_algorithm(RegallocAlgorithm::SinglePass);
config.cranelift_regalloc_algorithm(RegallocAlgorithm::SinglePass);
let engine = Engine::new(config)?;

let mut store = Store::new(&engine, ());
Expand Down