Some #farm improvements
#4561
Some #farm improvements
#4561
Conversation
|
I noticed the original |
There was a problem hiding this comment.
Just noticed that I have pending comments on this. The review is probably incomplete, but I'll submit it now before I forget it again.
Having FarmProcess enable and disable itself in a kind of paused-but-not-quite state looks really weird. Is there a reason to not have it return a DEFER pathing command while it is waiting for crops?
| /** | ||
| * Farm whitelist, only interact with crop that is on the {@link #farmWhitelist} list | ||
| */ | ||
| public final Setting<Boolean> farmEnableWhitelist = new Setting<>(false); | ||
|
|
||
| /** | ||
| * Crop block that Baritone is allowed to farm and collect | ||
| * {@link #farmEnableWhitelist} | ||
| */ | ||
|
|
||
| public final Setting<List<Block>> farmWhitelist = new Setting<>(new ArrayList<>(Arrays.asList( | ||
| Blocks.WHEAT, | ||
| Blocks.POTATOES, | ||
| Blocks.CARROTS | ||
| ))); |
There was a problem hiding this comment.
The whitelist should default to allowing everything so farmEnableWhitelist is not needed.
Also I'm not sure whether we really should use Block rather than a new enum type for farm targets.
There was a problem hiding this comment.
The whitelist should default to allowing everything so
farmEnableWhitelistis not needed.
you're right.
Also I'm not sure whether we really should use
Blockrather than a new enum type for farm targets.
i don't know, but yeah creating an enum would be consistent with the FarmProcess.class
| @@ -1397,7 +1436,7 @@ public final class Settings { | |||
| /** | |||
| * Desktop notification on farm fail | |||
| */ | |||
| public final Setting<Boolean> notificationOnFarmFail = new Setting<>(true); | |||
| public final Setting<Boolean> notificationOnFarmProcess = new Setting<>(true); | |||
There was a problem hiding this comment.
Why did you rename this?
There was a problem hiding this comment.
to avoid confusion while testing, i forgot to change it back
| public Long getTime() { | ||
| return time; | ||
| } | ||
|
|
||
| public void setTime(Long time) { | ||
| this.time = time; | ||
| } | ||
|
|
There was a problem hiding this comment.
okay, should be private, i guess? im new to this
|
why was this never added in the stable branch? |
-to conserve Power Usage for 24/7 auto farming (i don't know if there is a better way) |
added options:
changed:
#farm <range>partially resolves #396 #893 #3537
closes #775 #2315