feat: Failover history tab #1071
Merged
+166
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a feature-flagged "Failovers" tab to the domain page, controlled by the FAILOVER_HISTORY_ENABLED configuration. The tab displays a placeholder component and is hidden when the feature flag is disabled.
Key Changes:
- Adds conditional tab rendering based on the
FAILOVER_HISTORY_ENABLEDfeature flag - Implements a new placeholder
DomainPageFailoverscomponent - Updates test suite to verify tab visibility for both enabled and disabled states
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
domain-page-tabs.tsx |
Adds feature flag check and conditional tab filtering logic using useSuspenseConfigValue and lodash/omit |
domain-page-tabs.test.tsx |
Updates tests to verify tab rendering with feature flag enabled/disabled, adds error handling test |
domain-page-failovers.tsx |
Creates new placeholder component for the Failovers tab |
domain-page-tabs.config.ts |
Registers the new Failovers tab with icon, content component, and error configuration |
resolver-schemas.ts |
Adds schema definition for FAILOVER_HISTORY_ENABLED boolean config |
failover-history-enabled.ts |
Implements resolver that reads CADENCE_FAILOVER_HISTORY_ENABLED environment variable |
dynamic.config.ts |
Registers FAILOVER_HISTORY_ENABLED as a public request-time config |
resolved-config-values.ts |
Adds mock value for FAILOVER_HISTORY_ENABLED in test fixtures |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
adhityamamallan
force-pushed
the
failover-history-tab
branch
from
8698074 to
a6626c6
Compare
Copilot finished reviewing on behalf of
adhityamamallan
November 12, 2025 14:13
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Assem-Uber
approved these changes
Nov 13, 2025
Assem-Uber
pushed a commit
to Assem-Uber/cadence-web
that referenced
this pull request
Nov 19, 2025
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Unit tests + ran locally.
Disabled
Enabled