-
Notifications
You must be signed in to change notification settings - Fork 868
refactor: [shard-distributor]Handle context.Cancelled errors #7493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
gazi-yestemirova
wants to merge
10
commits into
cadence-workflow:master
from
gazi-yestemirova:store_err_logs
Closed
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
07c98ce
[shard-distributor]Remove error logs from store level
gazi-yestemirova 6b28caa
update tests
gazi-yestemirova a68b74f
fix(shard-distributor): remove trimming of prefixes (#7490)
eleonoradgr b94764d
feat(shard-distributor): return executor metadata from spectator GetS…
jakobht af3b6fa
handle context cancelled
gazi-yestemirova 8ff8c25
Merge branch 'master' of github.com:gazi-yestemirova/cadence into sto…
gazi-yestemirova 61d9aac
Merge branch 'master' of github.com:gazi-yestemirova/cadence into sto…
gazi-yestemirova ffa7b1d
move IsContextCancellation
gazi-yestemirova fcf94ce
remove etcdstore changes
gazi-yestemirova cf23b9f
rm space
gazi-yestemirova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to be some common/utils package
store/ looks like related to persistance, while context cancellation has nothing to do about it in general