Skip to content

refactor: First high level changes to getUsersAvailability #26566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
emrysal merged 10 commits into from
Jan 8, 2026
Merged

refactor: First high level changes to getUsersAvailability #26566

emrysal merged 10 commits into from
Jan 8, 2026

Conversation

@emrysal
Copy link
Contributor

@emrysal emrysal commented Jan 8, 2026 •
edited by cubic-dev-ai bot
Loading

Summary by cubic

Refactored getUsersAvailability to validate params upfront and rely on preloaded user data, reducing coupling and clarifying types. This also standardizes travel schedules, OOO notes, and busy slot source handling.

  • Refactors
    • Introduced GetUserAvailabilityParams (Dayjs dateFrom/dateTo) and moved parsing/validation to getUsersAvailability.
    • Removed internal getUser; callers must supply the user (via initialData or provided users array).
    • Expanded user shape with credentials, selected calendars, and travelSchedules; updated types accordingly.
    • Built travelSchedules only for default schedules and passed them to buildDateRanges.
    • Simplified OOO mapping (hide notes when not public, safer optional fields) and used params.withSource consistently for busy slot sources.
    • Updated API and TRPC handlers to validate date ranges and pass Dayjs dates to the service.

Written for commit 7f99736. Summary will update on new commits.

@vercel
Copy link

vercel bot commented Jan 8, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments
Project Deployment Review Updated (UTC)
api-v2 Ignored Ignored Preview Jan 8, 2026 3:58pm
cal Ignored Ignored Jan 8, 2026 3:58pm
cal-companion Ignored Ignored Preview Jan 8, 2026 3:58pm
cal-eu Ignored Ignored Jan 8, 2026 3:58pm

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026 •
edited
Loading

E2E results are ready!

@emrysal emrysal marked this pull request as ready for review January 8, 2026 14:41
@emrysal emrysal requested a review from a team as a code owner January 8, 2026 14:41
@graphite-app graphite-app bot added foundation core area: core, team members only labels Jan 8, 2026
@emrysal emrysal enabled auto-merge (squash) January 8, 2026 14:42
volnei
volnei approved these changes Jan 8, 2026
View reviewed changes
Copy link
Contributor

@volnei volnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@emrysal emrysal merged commit 23ecd1c into main Jan 8, 2026
50 of 51 checks passed
@emrysal emrysal deleted the refactor/move-parsing-in-get-users-availability branch January 8, 2026 14:45
cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Jan 8, 2026
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

@keithwillcode keithwillcode added this to the v6.1 milestone Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@volnei volnei volnei approved these changes

Assignees

No one assigned

Labels

core area: core, team members only foundation ready-for-e2e size/L

Projects

None yet

Milestone

v6.1

Development

Successfully merging this pull request may close these issues.

4 participants

@emrysal @volnei @keithwillcode