Skip to content

Rewrite Expo Plugin #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Rewrite Expo Plugin #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8be83c
rewrite expo plugin
baveku Oct 21, 2025
18380e1
example: add plugin to app.json
baveku Oct 21, 2025
5605d6c
example: add plugin to app.json
baveku Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/example/app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
}
],
"plugins": [
["react-native-edge-to-edge", {"android": {"parentTheme": "Material3"}}]
["react-native-edge-to-edge", {"android": {"parentTheme": "Material3"}}],
"react-native-bottom-tabs"
],
"resources": {
"android": [
Expand Down
3 changes: 2 additions & 1 deletion packages/react-native-bottom-tabs/app.plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
module.exports = require('./lib/module/expo');
module.exports = require('./plugin/build');

3 changes: 2 additions & 1 deletion packages/react-native-bottom-tabs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"test": "jest",
"typecheck": "tsc -b",
"lint": "eslint \"**/*.{js,ts,tsx}\"",
"build": "bob build"
"build": "bob build && expo-module build plugin"
},
"keywords": [
"react-native",
Expand All @@ -67,6 +67,7 @@
"@react-native/eslint-config": "0.81.1",
"@types/jest": "^29.5.5",
"@types/react": "^18.2.44",
"expo-module-scripts": "^5.0.7",
"react": "^19.1.0",
"react-native": "0.81.1",
"react-native-builder-bob": "^0.40.13",
Expand Down
0 ...ages/react-native-bottom-tabs/src/expo.ts → ...ct-native-bottom-tabs/plugin/src/index.ts
View file
Open in desktop
File renamed without changes.
9 changes: 9 additions & 0 deletions packages/react-native-bottom-tabs/plugin/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"extends": "expo-module-scripts/tsconfig.plugin",
"compilerOptions": {
"outDir": "build",
"rootDir": "src"
},
"include": ["./src"],
"exclude": ["**/__mocks__/*", "**/__tests__/*"]
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Source Files for Plugin Build

The app.plugin.js now requires from ./plugin/build, but the diff doesn't include any source files in plugin/src that tsconfig.json expects to build this output. This means the required path will not exist, causing a module resolution error.

Additional Locations (1)

Fix in Cursor Fix in Web

1 change: 1 addition & 0 deletions packages/react-native-bottom-tabs/plugin/tsconfig.tsbuildinfo
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"root":["./src/index.ts"],"version":"5.9.2"}
Loading
Loading