-
Notifications
You must be signed in to change notification settings - Fork 222
feat(sm): reference architeture link updates #5142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sm): reference architeture link updates #5142
Conversation
👋 🤖 🤔 Hello, @leiicamundi! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving my initial feedback on this.
Mostly links being 404.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leaving this as a single comment for the file to switch it to main
for the next
version.
docs/self-managed/setup/deploy/amazon/openshift/terraform-setup-dual-region.md
Outdated
Show resolved
Hide resolved
docs/self-managed/setup/deploy/amazon/openshift/terraform-setup-dual-region.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-8.7/self-managed/setup/deploy/openshift/redhat-openshift.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-8.7/self-managed/setup/deploy/openshift/redhat-openshift.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-8.7/self-managed/setup/deploy/openshift/redhat-openshift.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-8.7/self-managed/setup/deploy/openshift/redhat-openshift.md
Outdated
Show resolved
Hide resolved
versioned_docs/version-8.7/self-managed/setup/deploy/openshift/redhat-openshift.md
Show resolved
Hide resolved
had a quick look over the rendered docs and the bash references seem to all be in place properly except for the ones not working with 404. |
versioned_docs/version-8.7/self-managed/setup/deploy/openshift/redhat-openshift.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running through the links and formatting, everything seems to have been resolved/works well for me, so I think this PR will be ready to merge when you are. Would you like a hold label on it to ensure it isn't merged in advance?
Happy to approve and coordinate a specific release for you if you need to time it with the other repo, just let me know!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small comment which isn't hindering a merge or so.
Had a quick check with lychee --include-verbatim
and seems like all 404 were resolved 🚀.
The preview environment relating to the commit df69c04 has successfully been deployed. You can access it at https://preview.docs.camunda.cloud/pr-5142/index.html |
Description
InfraEx is consolidating all the reference architectures in a single repository: https://github.com/camunda/camunda-deployment-references
This PR address relocation of the content from the old repos to the new one.
As some links were already using the new repo, this PR should be merged when a documentation release is planned as the PRs below will be break the existing live doc when merged.
To be replaced after each PR is merged
SM changes:
stable/8.6
feature/rosa-8.7
=>main
feature/rosa-8.8
=> will remain unmerged, we will wait until 8.7 is released to integrate itTODO
When should this change go live?
bug
orsupport
label)available & undocumented
label)hold
label)low prio
label)PR Checklist
/docs
directory (version 8.8)./versioned_docs/version-8.7/
directory (version 8.7)./versioned_docs
directory.@camunda/tech-writers
unless working with an embedded writer.