Skip to content

Conversation

eric-pSAP
Copy link
Contributor

@eric-pSAP eric-pSAP commented Sep 30, 2025

This is meant to add more information as well as clarify current information. Also want to align with the README of the Java version of Attachments. Steps remaining:

  • Finalize structure and sections
    • Removing Java-specific sections and information
  • Confirm and clarify details
  • Add in links to sources

This initial change should make the rest of the editing process more streamlined

@eric-pSAP eric-pSAP self-assigned this Sep 30, 2025
@eric-pSAP eric-pSAP added documentation Improvements or additions to documentation good first issue Good for newcomers labels Sep 30, 2025
@KoblerS KoblerS self-requested a review October 7, 2025 14:21
eric-pSAP and others added 8 commits October 8, 2025 10:40
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Copy link
Contributor Author

@eric-pSAP eric-pSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transferring old notes

Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Copy link
Contributor

@lisajulia lisajulia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eric-pSAP!

Can you please double check if the following statements are true:

  • when running the application completely locally (not in hybrid mode), the attachements are stored locally in the database
  • when running the application in production, an object store binding is needed
  • to test with an object store binding, you need a such an object store binding, typically one provisioned through SAP BTP, to test you use a hybrid setup
  • currently, only the AWS-S3 object store is supported

I'm pretty sure, the above are all true.

Can you also doublecheck:

  • you can turn off the malware scanner by setting "attachments": {"scan": false}
  • even if malware scan is turned off: the file size restriction "max 400 MB" is still active
  • doublecheck the scan status codes please as well

And then make sure these things are reflected in the README :) - I think I've covered the spots concerning the object store...

Thanks a lot!!!

@eric-pSAP
Copy link
Contributor Author

Can you also doublecheck:

  • you can turn off the malware scanner by setting "attachments": {"scan": false}
  • even if malware scan is turned off: the file size restriction "max 400 MB" is still active
  • doublecheck the scan status codes please as well
  1. Yes you can, and it works
  2. File size is still restricted even with scanner off
  3. Status codes are indeed correct (although I have not seen "infected" in action before)

@lisajulia
Copy link
Contributor

lisajulia commented Oct 16, 2025

@eric-pSAP: We might want to ask for a review from @renejeglinsky as well!

@renejeglinsky: We try to align the documentation of https://github.com/cap-java/cds-feature-attachments and this attachments-node-plugin. If you have time, could you also have a look at this! Thanks!

@eric-pSAP eric-pSAP requested a review from KoblerS October 16, 2025 08:22
eric-pSAP and others added 11 commits October 16, 2025 12:59
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
@eric-pSAP eric-pSAP requested a review from KoblerS October 16, 2025 12:53
eric-pSAP and others added 2 commits October 16, 2025 15:00
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
@eric-pSAP eric-pSAP requested a review from KoblerS October 16, 2025 13:01
@KoblerS KoblerS marked this pull request as ready for review October 16, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants