-
Notifications
You must be signed in to change notification settings - Fork 10
Overhaul and Cleanup of the README File #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transferring old notes
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @eric-pSAP!
Can you please double check if the following statements are true:
- when running the application completely locally (not in hybrid mode), the attachements are stored locally in the database
- when running the application in production, an object store binding is needed
- to test with an object store binding, you need a such an object store binding, typically one provisioned through SAP BTP, to test you use a hybrid setup
- currently, only the AWS-S3 object store is supported
I'm pretty sure, the above are all true.
Can you also doublecheck:
- you can turn off the malware scanner by setting "attachments": {"scan": false}
- even if malware scan is turned off: the file size restriction "max 400 MB" is still active
- doublecheck the scan status codes please as well
And then make sure these things are reflected in the README :) - I think I've covered the spots concerning the object store...
Thanks a lot!!!
|
@eric-pSAP: We might want to ask for a review from @renejeglinsky as well! @renejeglinsky: We try to align the documentation of https://github.com/cap-java/cds-feature-attachments and this attachments-node-plugin. If you have time, could you also have a look at this! Thanks! |
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
Co-authored-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
This is meant to add more information as well as clarify current information. Also want to align with the README of the Java version of Attachments. Steps remaining:
This initial change should make the rest of the editing process more streamlined