Enhance memory management and error handling in attachment processing #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
KoblerS
commented
Oct 15, 2025
KoblerS
commented
- Refactor content handling in AWSAttachmentsService to ensure cleanup after uploads.
- Improve error handling in malwareScanner by streaming files directly to the scanner.
- Optimize memory usage in basic.js and plugin.js by clearing content references post-upload.
- Refactor content handling in AWSAttachmentsService to ensure cleanup after uploads. - Improve error handling in malwareScanner by streaming files directly to the scanner. - Optimize memory usage in basic.js and plugin.js by clearing content references post-upload.
|
@schiwekM, @eric-pSAP ready for review. |
vlovini
approved these changes
Oct 15, 2025
KoblerS
force-pushed
the
263-version-222-server-crashes-with-oom-during-file-upload-and-virus-scanning
branch
from
9071afd to
55a0f06
Compare
KoblerS
force-pushed
the
263-version-222-server-crashes-with-oom-during-file-upload-and-virus-scanning
branch
from
55a0f06 to
a18b48c
Compare
…sages and ensuring proper stream cleanup
…t of AttachmentsSrv.get
schiwekM
approved these changes
Oct 16, 2025
KoblerS
deleted the
263-version-222-server-crashes-with-oom-during-file-upload-and-virus-scanning
branch
KoblerS
added a commit
that referenced
this pull request
Oct 16, 2025
…#270) - Refactor content handling in AWSAttachmentsService to ensure cleanup after uploads. - Improve error handling in malwareScanner by streaming files directly to the scanner. - Optimize memory usage in basic.js and plugin.js by clearing content references post-upload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.