Skip to content

fix: error parsing cursor on getMany share handler #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: error parsing cursor on getMany share handler #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2802a9
fix: parsing error of cursor in pagination
Raju-kadel-27 Aug 11, 2024
823ab8d
chore: change _delete to deleteOne (handler name)
Raju-kadel-27 Aug 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/server/api/routes/share/delete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const ResponseSchema = z.object({
}),
});

export const _delete = withAuthApiV1
export const deleteOne = withAuthApiV1
.createRoute({
method: "delete",
path: "/v1/{companyId}/shares/{id}",
Expand Down
6 changes: 6 additions & 0 deletions src/server/api/routes/share/getMany.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,12 @@ export const getMany = withAuthApiV1
.withCursor({
limit: query.limit,
after: query.cursor,
getCursor({ id }) {
return id;
},
parseCursor(cursor) {
return { id: cursor };
},
});

const response: z.infer<typeof ResponseSchema> = {
Expand Down
4 changes: 2 additions & 2 deletions src/server/api/routes/share/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import type { PublicAPI } from "@/server/api/hono";
import { create } from "./create";
import { _delete } from "./delete";
import { deleteOne } from "./delete";
import { getMany } from "./getMany";
import { getOne } from "./getOne";
import { update } from "./update";

export const registerShareRoutes = (api: PublicAPI) => {
api.openapi(_delete.route, _delete.handler);
api.openapi(deleteOne.route, deleteOne.handler);
api.openapi(getOne.route, getOne.handler);
api.openapi(getMany.route, getMany.handler);
api.openapi(create.route, create.handler);
Expand Down