Skip to content

fix: invisibility of incorporation type inside company settings #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: invisibility of incorporation type inside company settings #523

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9af50c4
fix: make safe actions as client component
Raju-kadel-27 Sep 25, 2024
ee7905c
fix: default selection of incorporation type inside company settings
Raju-kadel-27 Sep 25, 2024
5069b90
chore: remove unwanted code
Raju-kadel-27 Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 29 additions & 4 deletions src/components/onboarding/company-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,11 +194,30 @@ export const CompanyForm = ({ type, data }: CompanyFormProps) => {

const isDirty = form.formState.isDirty;

type IncorpType = "llc" | "c-corp" | "s-corp" | "other";

const existingIncorpType = data?.company.incorporationType as IncorpType;

const humanizeIncorpType = (key: IncorpType) => {
switch (key) {
case "llc":
return "LLC - Limited Liability Company";
case "c-corp":
return "C-Corp - C Corporation";
case "s-corp":
return "S-Corp - S Corporation";
case "other":
return "Others or International";
default:
return "Unknown Incorporation Type";
}
};

const incorpTypeOpts = [
{ value: "llc", label: "LLC - Limited Liability Company" },
{ value: "c-corp", label: "C-Corp - C Corporation" },
{ value: "s-corp", label: "S-Corp - S Corporation" },
{ value: "other", label: "Others or International" },
{ value: "llc", label: humanizeIncorpType("llc") },
{ value: "c-corp", label: humanizeIncorpType("c-corp") },
{ value: "s-corp", label: humanizeIncorpType("s-corp") },
{ value: "other", label: humanizeIncorpType("other") },
];

return (
Expand Down Expand Up @@ -425,6 +444,12 @@ export const CompanyForm = ({ type, data }: CompanyFormProps) => {
{/* Used Linear-combobox instead of Select Component */}
<div>
<LinearCombobox
defaultOption={{
value: existingIncorpType ?? "",
label: existingIncorpType
? humanizeIncorpType(existingIncorpType)
: "Select type",
}}
options={incorpTypeOpts}
onValueChange={(option) => {
field.onChange(option.value);
Expand Down