-
Notifications
You must be signed in to change notification settings - Fork 2
chore: gen class #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: gen class #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sotatek-DucPhung Feel free to reply to my comments, but latest priorities as shared on Slack take priority tomorrow. Patrick can maybe pick this up later.
enabled = false | ||
} | ||
|
||
tasks.openApiGenerate { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the command called to the README somewhere so people know how to re-generate types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this PR, we should generate the types and commit them, and them import them to the APIs for use to replace Object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on slack discussion, there were validation issues in the spec. Can we coordinate with Patrick to see if we can fix those on the KERIA side, instead of adding this file?
implementation "org.json:json:${jsonVersion}" | ||
implementation "org.greenbytes.http:structured-fields:${structuredFieldsVersion}" | ||
// OpenAI generate model dependencies | ||
implementation "com.squareup.okhttp3:okhttp:4.12.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this one needed specifically?
implementation "org.greenbytes.http:structured-fields:${structuredFieldsVersion}" | ||
// OpenAI generate model dependencies | ||
implementation "com.squareup.okhttp3:okhttp:4.12.0" | ||
implementation "com.google.code.gson:gson:2.11.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have jackson - can we configure it to use that instead?
|
||
tasks.openApiGenerate { | ||
generatorName.set("java") | ||
inputSpec.set("$rootDir/spec.yaml") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it need to come from a file or can make a HTTP call to KERIA in real time?
No description provided.