Skip to content

Conversation

Sotatek-DucPhung
Copy link
Collaborator

No description provided.

@Sotatek-DucPhung Sotatek-DucPhung marked this pull request as draft September 4, 2025 09:14
@iFergal iFergal self-requested a review September 9, 2025 19:27
Copy link
Collaborator

@iFergal iFergal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sotatek-DucPhung Feel free to reply to my comments, but latest priorities as shared on Slack take priority tomorrow. Patrick can maybe pick this up later.

enabled = false
}

tasks.openApiGenerate {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the command called to the README somewhere so people know how to re-generate types?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this PR, we should generate the types and commit them, and them import them to the APIs for use to replace Object

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on slack discussion, there were validation issues in the spec. Can we coordinate with Patrick to see if we can fix those on the KERIA side, instead of adding this file?

implementation "org.json:json:${jsonVersion}"
implementation "org.greenbytes.http:structured-fields:${structuredFieldsVersion}"
// OpenAI generate model dependencies
implementation "com.squareup.okhttp3:okhttp:4.12.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this one needed specifically?

implementation "org.greenbytes.http:structured-fields:${structuredFieldsVersion}"
// OpenAI generate model dependencies
implementation "com.squareup.okhttp3:okhttp:4.12.0"
implementation "com.google.code.gson:gson:2.11.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have jackson - can we configure it to use that instead?


tasks.openApiGenerate {
generatorName.set("java")
inputSpec.set("$rootDir/spec.yaml")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to come from a file or can make a HTTP call to KERIA in real time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants