Skip to content

Conversation

Sotatek-Patrick-Vu
Copy link
Collaborator

No description provided.

body.put("acdc", acdc.getKed());
body.put("iss", iss.getKed());
if (atc != null && !atc.isEmpty()) {
body.put("atc", atc);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This atc is for iss only? Maybe we can update it to pass both atcs and update KERIA. It'll be more flexible in the future

assertEquals(registryName, registryData.get("name"));

return registryData;
} catch (IOException | InterruptedException | DigestException e) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an easy way to avoid all these try catches in tests? I know it's all over the repo, it's overdue a cleanup in another PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already handled exceptions in TestSteps, let me remove try/catch in this test file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants