chore: remove references to any in src/keri/core directory #12

Sotatek-DukeVu · 2025-08-08T10:41:20Z

Remove references to any in src/keri/core directory
Issue: WebOfTrust#340

src/keri/app/clienting.ts

src/keri/core/eventing.ts

src/keri/app/clienting.ts

src/keri/app/controller.ts

src/keri/core/eventing.ts

src/keri/app/delegating.ts

src/keri/core/eventing.ts

src/keri/app/controller.ts

src/keri/core/eventing.ts

src/keri/app/clienting.ts

src/keri/app/contacting.ts

src/keri/core/httping.ts

src/keri/core/tholder.ts

src/keri/app/exchanging.ts

src/keri/app/habery.ts

iFergal · 2025-11-04T17:21:09Z

src/keri/core/eventing.ts

+) &
+    Record<string, unknown> &
+    BaseSAD;
+export type InteractEventData = components['schemas']['Seal'];


As mentioned during the previous review rounds - this is actually a SealSourceTriple based on where it's used.

Interaction events can anchor any type of data, and a SealSourceTriple is a common one.

@Sotatek-DukeVu Please use this:
export type SealSourceTriple = components['schemas']['Seal']; for anywhere where we use i,s,d triples, such as for approving delegations.

The generic case for interaction events can use Record<string, unknown> inline.

iFergal · 2025-11-04T17:22:09Z

src/keri/app/coring.ts

You might need to merge main into this branch as it looks like we have changes from one of Patrick's PRs.

src/keri/app/controller.ts

src/types/keria-api-schema.ts

iFergal · 2025-11-05T16:17:48Z

src/keri/core/saider.ts

                if (code == undefined) {
                    if (sad[label] != '') {
-                        super({ qb64: sad[label], code: code });
+                        super({ qb64: String(sad[label]), code: code });


Not changed

iFergal · 2025-11-05T16:18:46Z

src/keri/core/salter.ts

 import libsodium from 'libsodium-wrappers-sumo';
 import { Tier } from '../../types/keria-api-schema.ts';

-export { Tier } from '../../types/keria-api-schema.ts';


You reverted this, but we are still importing from keria-api-schema in the integration tests. Can you update the exports to make sure it's not exported to the external facing API of the library?

iFergal · 2025-11-05T16:22:43Z

src/keri/core/eventing.ts

-    route: string = '',
-    data: any | undefined,
+    route: '/end/role/add',
+    data: EndRoleAddAttributes | undefined,


We still have as EndRoleAddAttributes in here.

iFergal · 2025-11-05T16:23:25Z

src/keri/core/eventing.ts

+
+export type DelegateInceptEventSAD =
+    | components['schemas']['DIP_V_1']
+    | components['schemas']['DIP_V_1'];


iFergal · 2025-11-05T16:42:26Z

src/keri/app/controller.ts

            pre: this.pre,
            keys: this.keys,
-            dig: this.serder.sad['d'],
+            dig: this.serder.sad['d'] as string,


Same here, not needed

iFergal · 2025-11-05T16:43:11Z

src/keri/app/controller.ts

-            pre: this.serder.pre,
-            dig: this.serder.sad['d'],
+            pre: this.serder.pre as string,
+            dig: this.serder.sad['d'] as string,


Can you leave a TODO that these casts can be removed once SerderKERI and SerderACDC introduced?

iFergal · 2025-11-05T16:47:39Z

src/keri/core/serder.ts

    private _kind: Serials;
    private _raw: string = '';
-    private _sad: Dict<any> = {};
+    private _sad: T;


This snippet is from saider.ts, not serder.ts, so it shouldn't reference SerderSAD.

iFergal · 2025-11-05T16:48:31Z

src/keri/app/aiding.ts

+                    this.client.pidx
+                );
+                break;
+        }


Let me think about this one. I'm not a fan of how this function is handled in general. We can tackle it at the end.

iFergal · 2025-11-05T16:49:50Z

src/keri/core/serder.ts

    s?: string | number;
-}
+    d?: string;
+    i?: string;


Hmm, does i and d need to be optional? If so, maybe we should think about SerderKERI and SerderACDC for now. (But don't until I confirm tomorrow)

Sotatek-DukeVu force-pushed the chore/remove-reference-any-type branch from 647c35e to 03cad8d Compare August 8, 2025 10:45

Sotatek-DukeVu requested a review from iFergal August 8, 2025 10:45

Sotatek-DukeVu self-assigned this Aug 8, 2025

iFergal reviewed Aug 8, 2025

View reviewed changes

Sotatek-DukeVu force-pushed the chore/remove-reference-any-type branch from 67cc8d0 to 50384d4 Compare August 25, 2025 09:23

Sotatek-DukeVu changed the base branch from chore/openapi_type_hints to feat/agenting_type_hints August 25, 2025 09:24

iFergal reviewed Aug 25, 2025

View reviewed changes

Sotatek-Patrick-Vu force-pushed the feat/agenting_type_hints branch 2 times, most recently from 7ffb639 to 65186c9 Compare October 15, 2025 09:55

Sotatek-Patrick-Vu force-pushed the feat/agenting_type_hints branch from 65186c9 to 65af0ee Compare October 24, 2025 09:06

Sotatek-DukeVu force-pushed the chore/remove-reference-any-type branch from 7656c87 to e3b0194 Compare October 31, 2025 03:18

iFergal changed the base branch from feat/agenting_type_hints to main October 31, 2025 08:32

Sotatek-Patrick-Vu and others added 18 commits October 31, 2025 16:07

aiding.py type hints and auto-generated OpenAPI specs

17eee30

resolve review comments

0836c7c

fix mock data for aiding test

bbba902

resolve review comments

ee5a710

resolve review comments

949849a

convert old mockdata + recreate KEL types (all fields are required)

205945b

rebase and update code

a64028d

remove unuse test file

a8df631

update keria api schema

20ad810

aiding.py type hints and auto-generated OpenAPI specs

5452bb4

resolve review comments

3e036d1

feat: agenting.py type hints and OpenAPI specs #377

0dfa5cf

fix an error for multisig tests

0b0b481

fix after rebasing from parent branch

0eff0ae

fix conflicts and resolve review comments

edf0b90

aiding.py type hints and auto-generated OpenAPI specs

e71669b

resolve review comments

1abf2d9

chore: remove any type for decrypter, encrypter and utils

f9fdce6

Vu Van Duc added 5 commits October 31, 2025 16:22

feat(ui): replace any type

945ff45

chore: remove cast string

492d018

chore: update type

9366051

feat(ui): resolve conflict

a22640c

feat(ui): using openAI type

8849d57

Sotatek-DukeVu force-pushed the chore/remove-reference-any-type branch from eac99c5 to 8849d57 Compare October 31, 2025 09:42

chore: update type and revert wrong type

6765c05

Sotatek-DukeVu force-pushed the chore/remove-reference-any-type branch from d1eac26 to 6765c05 Compare November 3, 2025 04:23

iFergal reviewed Nov 4, 2025

View reviewed changes

chore: fix reviews comments

50fc3bd

iFergal reviewed Nov 5, 2025

View reviewed changes

Vu Van Duc added 2 commits November 6, 2025 15:41

chore: fix review comments

36bc675

chore: create SerderKeri class

78bbdcb

chore: remove references to any in src/keri/core directory #12

Are you sure you want to change the base?

chore: remove references to any in src/keri/core directory #12

Uh oh!

Conversation

Sotatek-DukeVu commented Aug 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iFergal Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

iFergal Nov 4, 2025 •

edited

Loading