feat: agenting.py type hints and OpenAPI specs #377 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sotatek-Patrick-Vu
force-pushed
the
feat/agenting_type_hints
branch
from
99a6dd5 to
2756a67
Compare
iFergal
reviewed
Aug 25, 2025
| * @returns {Promise<Operation<any>>} A promise to the long-running operation | ||
| */ | ||
| async resolve(oobi: string, alias?: string): Promise<any> { | ||
| async resolve(oobi: string, alias?: string): Promise<Operation<any>> { |
There was a problem hiding this comment.
I used any to avoid some syntax errors in current tests.
Do you think we should using unknown instead?
There was a problem hiding this comment.
I think lets do unknown for now and we can later get more specific operation response types
There was a problem hiding this comment.
Same for other places where we have any
| * @returns {Promise<Operation<any>>} A promise to the result | ||
| */ | ||
| async responded(source: string, said: string): Promise<Response> { | ||
| async responded(source: string, said: string): Promise<Operation<any>> { |
There was a problem hiding this comment.
Actually, not sure if we needed to change this file - otherwise we are changing the API
Sotatek-Patrick-Vu
force-pushed
the
feat/aiding_type_hints
branch
from
e673933 to
289f56c
Compare
Sotatek-Patrick-Vu
force-pushed
the
feat/agenting_type_hints
branch
from
bc7e842 to
7ffb639
Compare
Sotatek-Patrick-Vu
force-pushed
the
feat/agenting_type_hints
branch
from
7ffb639 to
65186c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.