Support runtime XML directory for libvirt collector #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Seems like certain Openstack deployments might not create XML files for instances in persistent directory `/etc/libvirt/qemu`. So, we need to support looking into the runtime directory `/run/libvirt/qemu` in the collector. By default collector will look at both directories and file found in the first directory will be used to fetch instance properties. We always give priority to persistent folder over runtime folder while looking for files. * Unit tests have been modified to test the behaviour of XML files in runtime and persistent directories which have different XML schemas. Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like certain Openstack deployments might not create XML files for instances in persistent directory
/etc/libvirt/qemu. So, we need to support looking into the runtime directory/run/libvirt/qemuin the collector. By default collector will look at both directories and file found in the first directory will be used to fetch instance properties. We always give priority to persistent folder over runtime folder while looking for files.Unit tests have been modified to test the behaviour of XML files in runtime and persistent directories which have different XML schemas.
Closes #403