Allow GPU fetching to fail for libvirt collector #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When GPUs are configured to use in passthrough mode, there is no gurantee that `nvidia-smi` command will return GPUs. In that case we should not block exporter from starting. In any case, we cannot fetch metrics of passed through GPUs so it should not block exporter. * Simulate the case in unit test Signed-off-by: Mahendra Paipuri <mahendra.paipuri@gmail.com>
mahendrapaipuri
deleted the
fix/exporter/libvirt/allow_gpu_fetch_to_fail
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When GPUs are configured to use in passthrough mode, there is no gurantee that
nvidia-smicommand will return GPUs. In that case we should not block exporter from starting. In any case, we cannot fetch metrics of passed through GPUs so it should not block exporter.Simulate the case in unit test
Ref: #402 (reply in thread)