Skip to content

Cycle through host before calling errback #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cycle through host before calling errback #2331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion kombu/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,11 +444,14 @@ def _ensure_connection(

def on_error(exc, intervals, retries, interval=0):
round = self.completes_cycle(retries)
# NOTE(arnaud/OVH) we changed this to select next host
# before going down to errback, because errback was raising
# a TimeoutError, preventing the retry to cycle through hosts
self.maybe_switch_next() # select next host
if round:
interval = next(intervals)
if errback:
errback(exc, interval)
self.maybe_switch_next() # select next host

return interval if round else 0

Expand Down