fix: handle synchronous exceptions in QueuedInterceptor #2478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where QueuedInterceptor would cause requests to hang indefinitely when an interceptor callback threw a synchronous exception.
The _handleQueue method now accepts an onError callback that properly completes the handler when a synchronous exception is caught, ensuring requests fail gracefully instead of hanging.
New Pull Request Checklist
mainbranch to avoid conflicts (via merge from master or rebase)CHANGELOG.mdin the corresponding packageAdditional context and info (if any)
Description
Fixes a bug where
QueuedInterceptorwould cause requests to hang indefinitely when an interceptor callback threw a synchronous exception.Problem
When using
QueuedInterceptor, if an interceptor callback (onRequest,onResponse, oronError) threw a synchronous exception (not wrapped in aFuture), the request would hang until timeout. This occurred because the_handleQueuemethod'stry-catchblock caught the exception but only called_processNextInQueue()without completing the handler'sCompleter, leaving the request waiting forever.Changes
Modified
_handleQueueto accept anonErrorcallback parameter that properly handles synchronous exceptions:DioExceptionand callshandler.reject()to fail the request gracefullyDioExceptionand callshandler.next()to pass the error to the next interceptor in the chain