chore: upgrade to bloodhound 0.25.0.0 #1178
Open
+398
−309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@blackheaven thanks a lot, we meant to do this upgrade for a while!
| Aeson.FromJSON a => | ||
| BH.IndexName -> | ||
| body -> | ||
| m [Json.Value] |
There was a problem hiding this comment.
Unfortunately, aeson is too slow for certain query, so we do need to keep json-syntax here. See: the test/JsonDecode.{hs,py} benchmark.
blackheaven
force-pushed
the
chore/bloodhound-025
branch
from
38fa901 to
e33b731
Compare
|
Not sure why it cannot parse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not run the tests or the project.