Skip to content

fix for Nim 1.2 + explain readInto EOF semantics #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix for Nim 1.2 + explain readInto EOF semantics #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8264d9c
fix compilation in Nim 1.2 on Windows
akavel Jun 3, 2020
23ed176
asyncpipe: explain readInto EOF detection semantics
akavel Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion asynctools/asyncpipe.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ when defined(nimdoc):
## into ``data``, which must at least be of that size.
##
## Returned future will complete once all the data requested is read or
## part of the data has been read.
## part of the data has been read. A future with value 0 means end of file.

proc asyncWrap*(readHandle: Handle|cint = 0,
writeHandle: Handle|cint = 0): AsyncPipe =
Expand Down Expand Up @@ -116,6 +116,7 @@ else:

when defined(windows):
import winlean
import asyncpty
else:
import posix

Expand Down