Remove support for versions of ruby prior to 2.6 #381
Conversation
marcparadise
force-pushed
the
mp/remove-eol-ruby
branch
from
7fdf4b4 to
14709ff
Compare
marcparadise
force-pushed
the
mp/remove-eol-ruby
branch
from
14709ff to
c69e8ca
Compare
marcparadise
force-pushed
the
mp/remove-eol-ruby
branch
from
c69e8ca to
b5d0ac2
Compare
|
Note that windows build was failing prior to this PR, and is not addressed here. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Will update this further - even though we can't test these older versions, there may still be cases where they get pulled in and will work (like chef-install cookbook for upgrades). After update, it will leave in 'soft' support (conditional gems by version) but remove the unsupported ruby versions. |
jaymzh
added
the
Status: Waiting on Contributor
|
@marcparadise ping? :) |
Ruby 2.5 and earlier are all EOL and are no longer receiving security updates. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
pry-byebug is not supported on all platforms, and is also not necessary for running pipeline tests. Excluding gem group 'debug' from tests prevents failures related to unsupported platforms. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com> Signed-off-by: Thomas Powell <thomas.powell@progress.com>
tpowell-progress
force-pushed
the
mp/remove-eol-ruby
branch
from
b5d0ac2 to
5b35ff0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
This relates to: #400 @marcparadise - I'm unclear on the status of this PR - I think we can merge, but it's been 2 years, so we should at least rebase. |
|
| spec.executables = ["mixlib-install"] | ||
| spec.require_paths = ["lib"] | ||
|
|
||
| spec.required_ruby_version = ">= 2.6.0" |
There was a problem hiding this comment.
I think we decided not to force newer versions so people can use this on like an old Mac to get the latest chef... we wanted to go "soft" min requirement.
| gem "webrick" | ||
| gem "webmock", "~> 3.4" | ||
| gem "contracts", "~> 0.16.0" # this entry can go away when ruby < 3 support is gone | ||
| if RUBY_VERSION < "2.6.0" |
There was a problem hiding this comment.
probably wanna leave the conditional here....
|
|
||
| gemspec | ||
|
|
||
| gem "chef-utils", "= 16.6.14" if RUBY_VERSION < "2.6.0" |
There was a problem hiding this comment.
shall we leave this as well?
|
|
@marcparadise Is this still needed? |
Ruby 2.5 and earlier are all EOL and are no longer receiving security updates.
Signed-off-by: Marc A. Paradise marc.paradise@gmail.com