Skip to content

Conversation

@ntoniazzi
Copy link

Hello,
I found this project very interesting, but the demo application is build upon an old, obsolete and insecure version of jQuery.
In this PR, I removed the dependency to jQuery. The resulting page is almost identical the the previous version (tested on Firefox, Chrome and Edge).
I also added a quick waveform visualization.

@chr15m
Copy link
Owner

chr15m commented Jul 11, 2022

Thank you, that's an interesting idea. I will try to find some time to review this.

@pisemsky
Copy link

pisemsky commented Aug 5, 2025

Hi, how about adding this new UI under a different name like jsfxr.html and keeping the current one and jquery untouched?

Then the new one can be used/improved and the current one eventually dropped.

BTW jquery is licensed under MIT, while the current UI depends on it and states itself as "unlicensed" - IANAL, but less permissive can't be a part of more permissive.

@chr15m
Copy link
Owner

chr15m commented Aug 5, 2025

BTW jquery is licensed under MIT, while the current UI depends on it and states itself as "unlicensed" - IANAL, but less permissive can't be a part of more permissive.

No you have it backwards. A problem can arise when you try to use a more permissive library in a less permissive application, e.g. GPL in a proprietary app. The MIT licensee requires attribution, while The Unlicense license has no requirements at all. So an MIT licensed library can be used in an Unlicense licensed application with no problem.

Thanks for the PR, will take a look.

Can I also ask what problem these PRs solve? Is jQuery UI causing some issue or is it simply because it is "outdated"?

I'm not a huge fan of software churn for the sake of new and shiny code. If there is a user facing problem then I'm all ears.

@ntoniazzi
Copy link
Author

I'm not a huge fan of software churn for the sake of new and shiny code. If there is a user facing problem then I'm all ears.

When I was searching for a tool to generate simple sounds, I found jsfrx and immediately liked its simple and concise yet complete interface. The whole lib is less than 36kb, and the UI only 20kb.

jQuery comes from a dark age where brothers lacked easy tools to manipulate the DOM, some UI widgets, and behaved differently from each other. Today, they have evolved. A lot. And almost every improvement provided by jQuery and jQuery-UI exists natively.

Without jQuery, your repository is 232kb lighter.

Page load with jquery:

  • 33 requests
  • 648KB

Without jquery:

  • 5 requests
  • 61KB

I see that the pro version of jsfxr uses react, and not jQuery ;-)

@chr15m
Copy link
Owner

chr15m commented Aug 9, 2025

Without jQuery, your repository is 232kb lighter.

Page load with jquery:
* 33 requests
* 648KB

Without jquery:
* 5 requests
* 61KB

Ok, that's a good reason to merge, thank you for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants