[CLN]: remove v1 of garbage collection

[codetheweb]

Description of changes

Removes a bunch of dead code.

Test plan

How are these changes tested?

• Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Migration plan

Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?

Observability plan

What is the plan to instrument and monitor this change?

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

[codetheweb]

• [CLN]: remove v1 of garbage collection #5627 : 2 dependent PRs (#5628 , #5720 ) 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[propel-code-bot]

Remove Legacy V1 Garbage Collection Implementation and Consolidate on V2

This PR removes the original ('v1') garbage collection orchestrator, operators, tests, and all related code from the rust/garbage_collector codebase. The GC system now exclusively uses the v2 orchestrator and associated logic. Code and tests are updated to reference only v2 types and modes, and unnecessary GC modes are eliminated, simplifying the options to only support v2 behaviors.

Key Changes

• Deleted the v1 orchestrator implementation (rust/garbage_collector/src/garbage_collector_orchestrator.rs), associated property and integration tests (rust/garbage_collector/tests/prop_test_local_files.rs), and redundant GC modes.
• Modified CleanupMode in rust/garbage_collector/src/types.rs to only support Rename (soft-delete), DryRunV2, and DeleteV2 (hard delete). Removed is_v2() logic.
• Updated all operators, orchestrators, and tests to use v2 cleanup modes and logic, removing any fallback or conditional logic for v1.
• Refactored rust/garbage_collector/src/garbage_collector_component.rs and related code to dispatch only v2 orchestrator jobs and collection processing.
• Simplified and cleaned up test/utility clients, helpers, function signatures, and variant usages that previously handled v1/v2 branching or v1-specific calls.

Affected Areas

• garbage collection orchestrator lifecycle and job dispatch
• test infrastructure for property and integration tests
• file deletion and log cleanup operator implementations
• project-wide usages and definition of CleanupMode
• test utilities and helper client code

This summary was automatically generated by @propel-code-bot

[Sicheng-Pan]

do we still need this? (if no we could remove this in a separate PR)

[codetheweb]

good catch no I think we can remove this too
will do separately