Skip to content

Conversation

@Bharatkk-metron
Copy link

@Bharatkk-metron Bharatkk-metron commented Dec 30, 2025

Update Doppel API Auth headers and entity/queue state parameters

Description

Doppel has made changes to the APIs. This pull request includes the changes that sync the code with the Doppel API changes.
For more information, please check the API document of Dopple here: https://doppel.readme.io/reference/create_alert.

What problem does this PR solve?

  • Doppel APIs introduced new headers for its APIs. The PR update manager class to use the newly introduced API headers
  • Doppel APIs updated the value for entity/queue state for alerts. The PR leverages the changes

How does this PR solve the problem?

  • The PR includes the newly introduced headers, removes unsupported values, and adds newly supported values for entity and queue state

Checklist:

Please ensure you have completed the following items before submitting your PR.
This helps us review your contribution faster and more efficiently.

General Checks:

  • I have read and followed the project's contributing.md guide.
  • My code follows the project's coding style guidelines.
  • I have performed a self-review of my own code.
  • My changes do not introduce any new warnings.
  • My changes pass all existing tests.
  • I have added new tests where appropriate to cover my changes. (If applicable)
  • I have updated the documentation where necessary (e.g., README, API docs). (If applicable)

Open-Source Specific Checks:

  • My changes do not introduce any Personally Identifiable Information (PII) or sensitive customer data.
  • My changes do not expose any internal-only code examples, configurations, or URLs.
  • All code examples, comments, and messages are generic and suitable for a public repository.
  • I understand that any internal context or sensitive details related to this work are handled separately in internal systems (Buganizer for Google team members).

For Google Team Members and Reviewers Only:

  • I have included the Buganizer ID in the PR title or description (e.g., "Internal Buganizer ID: 123456789" or "Related Buganizer: go/buganizer/123456789").
  • I have ensured that all internal discussions and PII related to this work remain in Buganizer.
  • I have tagged the PR with one or more labels that reflect the pull request's purpose.

Screenshots (If Applicable)

If your changes involve UI or visual elements, please include screenshots or GIFs here.
Ensure any sensitive data is redacted or generalized.


Further Comments / Questions

Any additional comments, questions, or areas where you'd like specific feedback?

@Bharatkk-metron Bharatkk-metron requested a review from a team as a code owner December 30, 2025 14:41
@google-cla
Copy link

google-cla bot commented Dec 30, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Bharatkk-metron, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the DoppelVision integration to ensure full compatibility with recent changes in the Doppel APIs. The core modifications involve adapting the authentication mechanism to include new API headers for enhanced security and multi-tenancy support, as well as synchronizing the available options for alert queue and entity states to match the current Doppel API specifications. These changes are crucial for the continued functionality and reliability of the integration.

Highlights

  • API Authentication Update: The DoppelVision integration now supports new authentication headers, User_API_Key and Organization_Code, which are passed to the DoppelManager for API calls.
  • Alert State Value Synchronization: The integration has been updated to reflect the latest supported values for Queue_State and Entity_State parameters in Doppel APIs, removing outdated options and adding new ones like 'archived'.
  • Integration Version Bump: The DoppelVision integration version has been updated from 2.0 to 3.0 to reflect these significant API compatibility changes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Doppel integration to align with recent API changes, including new authentication headers and updated alert state values. The changes are generally in the right direction.

However, I've identified a couple of important issues:

  1. The DoppelManager's __init__ method is missing required type annotations and has an outdated docstring, which violates the repository style guide.
  2. There is a critical inconsistency in the provider_name used for extracting configuration parameters in all action scripts. It's set to Doppel while the integration identifier is DoppelVision. This could cause the integration to fail to retrieve credentials.

Please review the detailed comments for suggestions on how to address these points.

@Bharatkk-metron Bharatkk-metron changed the title Doppel dev auth update Update Doppel API Auth headers and entity/queue state parameters Dec 30, 2025
@AmitJ98
Copy link
Contributor

AmitJ98 commented Dec 31, 2025

Hi @Bharatkk-metron ,
My name in Amit i will review your pr.
First of all please see https://github.com/chronicle/content-hub/blob/main/docs/contributing.md , and sign the google cla which required to contribute to this repository.
Secondly please resolve the gemini comments.
Feel free to contact me if you need any help.

@Bharatkk-metron
Copy link
Author

Hi @Bharatkk-metron , My name in Amit i will review your pr. First of all please see https://github.com/chronicle/content-hub/blob/main/docs/contributing.md , and sign the google cla which required to contribute to this repository. Secondly please resolve the gemini comments. Feel free to contact me if you need any help.

Hi Amit,

Thanks for sharing the contributing.md file. I have already went through it. Also signed the Google CLA as mentioned. Please find the Screenshot attached.

THank you!

image

@Bharatkk-metron
Copy link
Author

Bharatkk-metron commented Jan 2, 2026

Hi Amit, Just wanted to give you a heads up that using mp tool, we could not build and deploy the package in the SecOps tenant.

Just wanted to share the issue your reference here

  • When we are trying to add api key - its rejecting the base url
mp dev-env login --api-root https://<tenant-url>/ --api-key <API-KEY>

throws -

Credentials saved to /home/siddharth/.mp_dev_env.json
Credential verification failed: 404 Client Error: Not Found for url: https://<tenant-url>/api/external/v1/settings/GetSourceRepositorySettings
Credentials file removed. 
  • When we try to build the package in order to zip and test it -
mp build --integration doppel_vision

throws -

The following integrations could not be found in the commercial marketplace: doppel_vision

Building the following integrations in the the third_party marketplace: doppel_vision
Integration doppel_vision is not built

RemoteTraceback:
"""
-------------- bunch of errors ------------------
"""

ValueError: Failed to load integration doppel_vision

Thank you!

@AmitJ98
Copy link
Contributor

AmitJ98 commented Jan 4, 2026

Hi Amit, Just wanted to give you a heads up that using mp tool, we could not build and deploy the package in the SecOps tenant.

Just wanted to share the issue your reference here

  • When we are trying to add api key - its rejecting the base url
mp dev-env login --api-root https://<tenant-url>/ --api-key <API-KEY>

throws -

Credentials saved to /home/siddharth/.mp_dev_env.json
Credential verification failed: 404 Client Error: Not Found for url: https://<tenant-url>/api/external/v1/settings/GetSourceRepositorySettings
Credentials file removed. 
  • When we try to build the package in order to zip and test it -
mp build --integration doppel_vision

throws -

The following integrations could not be found in the commercial marketplace: doppel_vision

Building the following integrations in the the third_party marketplace: doppel_vision
Integration doppel_vision is not built

RemoteTraceback:
"""
-------------- bunch of errors ------------------
"""

ValueError: Failed to load integration doppel_vision

Thank you!

Hi,

  • About the mp dev-env i will check it out, make sure you run mp config . from repo root and your url and api key are correct.
  • Few changes need to be made for the build process to work:
  • in definition.yaml values cannt contain '_' for example: User_API_Key -> User API Key
  • add publish time to the release notes

Updated as per review comment

Signed-off-by: Bharatkk-metron <120458124+Bharatkk-metron@users.noreply.github.com>
Signed-off-by: Bharatkk-metron <120458124+Bharatkk-metron@users.noreply.github.com>
Signed-off-by: Bharatkk-metron <120458124+Bharatkk-metron@users.noreply.github.com>
@Bharatkk-metron
Copy link
Author

Hi Amit, Just wanted to give you a heads up that using mp tool, we could not build and deploy the package in the SecOps tenant.
Just wanted to share the issue your reference here

  • When we are trying to add api key - its rejecting the base url
mp dev-env login --api-root https://<tenant-url>/ --api-key <API-KEY>

throws -

Credentials saved to /home/siddharth/.mp_dev_env.json
Credential verification failed: 404 Client Error: Not Found for url: https://<tenant-url>/api/external/v1/settings/GetSourceRepositorySettings
Credentials file removed. 
  • When we try to build the package in order to zip and test it -
mp build --integration doppel_vision

throws -

The following integrations could not be found in the commercial marketplace: doppel_vision

Building the following integrations in the the third_party marketplace: doppel_vision
Integration doppel_vision is not built

RemoteTraceback:
"""
-------------- bunch of errors ------------------
"""

ValueError: Failed to load integration doppel_vision

Thank you!

Hi,

  • About the mp dev-env i will check it out, make sure you run mp config . from repo root and your url and api key are correct.
  • Few changes need to be made for the build process to work:
  • in definition.yaml values cannt contain '_' for example: User_API_Key -> User API Key
  • add publish time to the release notes

Thank you so much @AmitJ98, for your reply and feedback. We have updated the definition.yaml and the release notes file.
Thank you!

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Marketplace Validation Failed

Click to view the full report

Validation Report

🧩 Integrations
Pre-Build Stage

doppel_vision

Validation Name Details
⚠️ Uv Lock Error happened while executing a command: uv lock --check: Using CPython 3.11.14 interpreter at: /opt/hostedtoolcache/Python/3.11.14/x64/bin/python Resolved 59 packages in 728ms The lockfile at uv.lock needs to be updated, but --check was provided. To update the lockfile, run uv lock.

@AmitJ98 AmitJ98 added Partner and removed Community labels Jan 5, 2026
@AmitJ98
Copy link
Contributor

AmitJ98 commented Jan 5, 2026

Hi @Bharatkk-metron i see you fixed the issues with the build.
the things left to do before publish:

  • make sure that all the validation pass, you can run mp validate command mp validate --integration doppel_vision --only-pre-build , i see that your lock file is not updated. you can run uv lock to fix it
  • make sure that mp format . and mp check . (run from you integration root folder) passes.

when it ready comment on the pr and i will do final review before publishing the integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants