-
Notifications
You must be signed in to change notification settings - Fork 43
Update Doppel API Auth headers and entity/queue state parameters #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update Doppel API Auth headers and entity/queue state parameters #405
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @Bharatkk-metron, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the DoppelVision integration to ensure full compatibility with recent changes in the Doppel APIs. The core modifications involve adapting the authentication mechanism to include new API headers for enhanced security and multi-tenancy support, as well as synchronizing the available options for alert queue and entity states to match the current Doppel API specifications. These changes are crucial for the continued functionality and reliability of the integration. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Doppel integration to align with recent API changes, including new authentication headers and updated alert state values. The changes are generally in the right direction.
However, I've identified a couple of important issues:
- The
DoppelManager's__init__method is missing required type annotations and has an outdated docstring, which violates the repository style guide. - There is a critical inconsistency in the
provider_nameused for extracting configuration parameters in all action scripts. It's set toDoppelwhile the integration identifier isDoppelVision. This could cause the integration to fail to retrieve credentials.
Please review the detailed comments for suggestions on how to address these points.
content/response_integrations/third_party/community/doppel_vision/actions/CreateAbuseAlert.py
Show resolved
Hide resolved
content/response_integrations/third_party/community/doppel_vision/actions/Ping.py
Show resolved
Hide resolved
content/response_integrations/third_party/community/doppel_vision/core/DoppelManager.py
Outdated
Show resolved
Hide resolved
|
Hi @Bharatkk-metron , |
Hi Amit, Thanks for sharing the contributing.md file. I have already went through it. Also signed the Google CLA as mentioned. Please find the Screenshot attached. THank you!
|
|
Hi Amit, Just wanted to give you a heads up that using mp tool, we could not build and deploy the package in the SecOps tenant. Just wanted to share the issue your reference here
throws -
throws - Thank you! |
Hi,
|
Updated as per review comment Signed-off-by: Bharatkk-metron <120458124+Bharatkk-metron@users.noreply.github.com>
Signed-off-by: Bharatkk-metron <120458124+Bharatkk-metron@users.noreply.github.com>
Signed-off-by: Bharatkk-metron <120458124+Bharatkk-metron@users.noreply.github.com>
Thank you so much @AmitJ98, for your reply and feedback. We have updated the definition.yaml and the release notes file. |
|
❌ Marketplace Validation Failed Click to view the full reportValidation Report🧩 IntegrationsPre-Build Stagedoppel_vision
|
|
Hi @Bharatkk-metron i see you fixed the issues with the build.
when it ready comment on the pr and i will do final review before publishing the integration. |

Update Doppel API Auth headers and entity/queue state parameters
Description
Doppel has made changes to the APIs. This pull request includes the changes that sync the code with the Doppel API changes.
For more information, please check the API document of Dopple here: https://doppel.readme.io/reference/create_alert.
What problem does this PR solve?
How does this PR solve the problem?
Checklist:
Please ensure you have completed the following items before submitting your PR.
This helps us review your contribution faster and more efficiently.
General Checks:
Open-Source Specific Checks:
For Google Team Members and Reviewers Only:
Screenshots (If Applicable)
If your changes involve UI or visual elements, please include screenshots or GIFs here.
Ensure any sensitive data is redacted or generalized.
Further Comments / Questions
Any additional comments, questions, or areas where you'd like specific feedback?