-
Notifications
You must be signed in to change notification settings - Fork 9
feat: Scribble 2 - Electric Scribbaloo #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
424475a to
18b075c
Compare
5e8a2d8 to
00073b5
Compare
00073b5 to
402e5a5
Compare
|
Hmmm, double pages have an issue when it comes to lecterns: since it shows two pages at once, you can't skip a single page. This means if you're using double pages, flipping through a book increases the page number by two:
There are then a few things I can think of here:
Bedrock also shows two pages, but for this reason it has a different formula for calculating lectern signal strength. I don't want to change that. lecterns have it out for me, they're always the enemy of good ideas >:( |
|
Maybe this could be addressed by using the page where the cursor is. Because the cursor can only be on one page at a time so if I spectate someone in a lectern and he has double page layout and I don't I always would see the page where his cursor is at same goes for the signal strength. |
|
Definitely an interesting idea, I'm not sure how practical it would be, since it's not really an 'action' you take. Especially if you want to select a specific page for a redstone strength, you have to be really careful with how you move your mouse (think those website menus where if you accidentally move off the menu, it disappears and you have to redo it all over again). Though I don't have any better ideas. |
|
Oh sorry, now I realize that I didn't explain my idea properly: I didn't mean the mouse cursor, I meant the text cursor. |
|
Oh, well in that case, you can't edit lectern books in vanilla, so there is no text cursor :) |
|
Yeah, I figured it would have synergies with the editing GUI on lecterns feature, or if that is not present, the definitely lamer version: just a text cursor without the ability to edit. That way the user gets the information and give the user control. But I am also not 100% sold on the idea. I just thought it is a bit more elegant than adding a dedicated button. |
This way, other mods can override Scribble's behaviour.
I've been working for a little while on moving Scribble to it's own screens, instead of mixing into the vanilla
BookEditScreen(so the decision I didn't make in #58, though that rewrite made this a lot easier!). This makes the code a lot less complex by removing the mess that isBookEditScreenMixin, and a lot more flexible.It's rewritten so that book viewing and book editing build on the same book screen, which is also built with the ability to show multiple pages at once. Rich text editing is basically untouched (thanks to previous me moving all that logic to
RichEditBox), commands have been updated to support multi-pages.Doing this also wins a lot of mod compat (there's only 4 small mixins), though it loses some nice out-of-the-box compat (ex. Symbol Chat). Most importantly though, it opens up the door to a lot of future improvements. This is probably a large enough change to justify a 2.0 release :)
Closes #81
Closes #73
Closes #36
Works toward #91
Works toward #78 (though I don't think I'll do this one)
Works toward #23
Also in this PR:
@NullMarkedeverything.Still to do before this can be merged:
Center the original book screens if the config option is set.(i'll decide what to do here later)Decide if I want to keep YACL, if so, move text to translatable strings.(for now, we're keeping YACL, but I really want to move to a custom config system later)For later, not necessarily this PR:
(this is an old screenshot, the texture has since changed and the margins are less cramped)

(not sure if I'll keep the YACL config screen yet, but I definitely like the organisation and the option descriptions)
